-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throttler/vreplication: fix app name used by VPlayer #16578
Merged
shlomi-noach
merged 1 commit into
vitessio:main
from
planetscale:fix-vplayer-throttler-app-name
Aug 11, 2024
Merged
Throttler/vreplication: fix app name used by VPlayer #16578
shlomi-noach
merged 1 commit into
vitessio:main
from
planetscale:fix-vplayer-throttler-app-name
Aug 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
dbussink
approved these changes
Aug 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16578 +/- ##
==========================================
- Coverage 68.77% 68.76% -0.02%
==========================================
Files 1556 1556
Lines 199812 199812
==========================================
- Hits 137419 137399 -20
- Misses 62393 62413 +20 ☔ View full report in Codecov by Sentry. |
shlomi-noach
added
Backport to: release-18.0
Needs to be back ported to release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
labels
Aug 11, 2024
rohit-nayak-ps
approved these changes
Aug 11, 2024
shlomi-noach
added a commit
to planetscale/vitess
that referenced
this pull request
Aug 11, 2024
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added a commit
to planetscale/vitess
that referenced
this pull request
Aug 11, 2024
Signed-off-by: Shlomi Noach <[email protected]>
This was referenced Aug 11, 2024
shlomi-noach
added a commit
that referenced
this pull request
Aug 12, 2024
…16578) (#16581) Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added a commit
that referenced
this pull request
Aug 12, 2024
…16578) (#16579) Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added a commit
that referenced
this pull request
Aug 12, 2024
…16578) (#16580) Signed-off-by: Shlomi Noach <[email protected]>
venkatraju
pushed a commit
to slackhq/vitess
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-18.0
Needs to be back ported to release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Component: Throttler
Component: VReplication
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VPlayer
was incorrectly identifying itself to the throttler asvcopier
. As result, runningApplyThrottlerConfig --throttle-app=vplayer
made no effect on VPlayer. This PR fixes the problem.Related Issue(s)
Context: #16575 (this PR does not fix this issue, just related)
Backports
This is a bug. Backporting to 20, 19, 18 where this issue is relevant.
Checklist
Deployment Notes