Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttler/vreplication: fix app name used by VPlayer #16578

Merged

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Aug 11, 2024

Description

VPlayer was incorrectly identifying itself to the throttler as vcopier. As result, running ApplyThrottlerConfig --throttle-app=vplayer made no effect on VPlayer. This PR fixes the problem.

Related Issue(s)

Context: #16575 (this PR does not fix this issue, just related)

Backports

This is a bug. Backporting to 20, 19, 18 where this issue is relevant.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (bf0c5f8) to head (88c6758).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16578      +/-   ##
==========================================
- Coverage   68.77%   68.76%   -0.02%     
==========================================
  Files        1556     1556              
  Lines      199812   199812              
==========================================
- Hits       137419   137399      -20     
- Misses      62393    62413      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shlomi-noach shlomi-noach added Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 labels Aug 11, 2024
@shlomi-noach shlomi-noach merged commit f68e62d into vitessio:main Aug 11, 2024
137 checks passed
@shlomi-noach shlomi-noach deleted the fix-vplayer-throttler-app-name branch August 11, 2024 10:26
shlomi-noach added a commit to planetscale/vitess that referenced this pull request Aug 11, 2024
shlomi-noach added a commit to planetscale/vitess that referenced this pull request Aug 11, 2024
venkatraju pushed a commit to slackhq/vitess that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Component: Throttler Component: VReplication Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants