Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18 backport: Throttler/vreplication: fix app name used by VPlayer (#16578) #16581

Merged

Conversation

shlomi-noach
Copy link
Contributor

Manual backport of #16578 to 18.0

Description

VPlayer was incorrectly identifying itself to the throttler as vcopier. As result, running ApplyThrottlerConfig --throttle-app=vplayer made no effect on VPlayer. This PR fixes the problem.

Related Issue(s)

Context: #16575 (this PR does not fix this issue, just related)

Backports

This is a bug. Backporting to 20, 19, 18 where this issue is relevant.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach requested a review from a team August 11, 2024 10:57
@shlomi-noach shlomi-noach merged commit 64d8f6f into vitessio:release-18.0 Aug 12, 2024
104 checks passed
@shlomi-noach shlomi-noach deleted the backport-16578-to-18.0 branch August 12, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants