-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge VTTOP and VTROOT variables, setting VTROOT to what was VTTOP #5382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Tocker <[email protected]>
Remove mysql_flavor settings (do in different pr) Signed-off-by: Morgan Tocker <[email protected]>
morgo
force-pushed
the
morgo-remove-vttop
branch
from
October 31, 2019 02:27
7e8281f
to
dbeffa0
Compare
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
morgo
force-pushed
the
morgo-remove-vttop
branch
5 times, most recently
from
November 6, 2019 13:46
59ec12d
to
56331e1
Compare
Signed-off-by: Morgan Tocker <[email protected]>
morgo
force-pushed
the
morgo-remove-vttop
branch
from
November 6, 2019 14:37
56331e1
to
eb5b8da
Compare
Signed-off-by: Morgan Tocker <[email protected]>
…to morgo-remove-vttop Signed-off-by: Morgan Tocker <[email protected]>
morgo
force-pushed
the
morgo-remove-vttop
branch
2 times, most recently
from
November 29, 2019 19:09
95d871e
to
3540c7c
Compare
Signed-off-by: Morgan Tocker <[email protected]>
morgo
force-pushed
the
morgo-remove-vttop
branch
from
November 29, 2019 20:01
3540c7c
to
88f79bf
Compare
Change parts of bootstrap to run in build.sh instead Always execute build.sh as part of make build. Signed-off-by: Morgan Tocker <[email protected]>
Add dependency checking support. Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
morgo
force-pushed
the
morgo-remove-vttop
branch
5 times, most recently
from
December 2, 2019 20:49
27d90a5
to
bd1e6d5
Compare
morgo
force-pushed
the
morgo-remove-vttop
branch
from
December 6, 2019 16:49
9de8f7f
to
a160d00
Compare
morgo
changed the title
DRAFT remove vttop
Merge VTTOP and VTROOT variables, setting VTROOT to what was VTTOP
Dec 6, 2019
morgo
force-pushed
the
morgo-remove-vttop
branch
from
December 6, 2019 17:16
a160d00
to
c20689b
Compare
Signed-off-by: Morgan Tocker <[email protected]>
morgo
force-pushed
the
morgo-remove-vttop
branch
from
December 6, 2019 17:19
c20689b
to
170f8c1
Compare
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
morgo
force-pushed
the
morgo-remove-vttop
branch
2 times, most recently
from
December 6, 2019 20:18
14850f7
to
7ddd68e
Compare
Signed-off-by: Morgan Tocker <[email protected]>
…to morgo-remove-vttop Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
morgo
force-pushed
the
morgo-remove-vttop
branch
from
December 6, 2019 23:24
d675ca3
to
22822e5
Compare
Signed-off-by: Morgan Tocker <[email protected]>
morgo
force-pushed
the
morgo-remove-vttop
branch
from
December 7, 2019 02:07
81db95a
to
92ab2b2
Compare
Signed-off-by: Morgan Tocker <[email protected]>
morgo
force-pushed
the
morgo-remove-vttop
branch
from
December 7, 2019 02:11
92ab2b2
to
568b614
Compare
Pasting the result of
Worker and prepared_statements failing is expected, they are both disabled tests. |
I am going to close this in favor of #5527 so we don't pollute the commit history so much. |
systay
pushed a commit
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5378
The motivation for this patch is that it allows one to checkout the source code, and run
make build
and thenmake test
with no configuration required.VTROOT
is unfortunately still required for runtime, since configuration files and webfiles need to be located. We can fix this in #5502The Dockerfiles use the historical layout still, with a symlink from the new 'bin' location back to
/vt/bin
.The Docker test runner has been modified so that it will work without waiting for new docker images to be published. After this PR merges and we push new images, there is code in
docker/test/run.sh
which can be removed.Note: This also disables the prepared statement test. See: #5524
Backwards Compatibility
This PR is intended to be mostly backwards compatible, however users will need to update their environment variables to point
$VTROOT
to the correct location (what wasVTTOP
).This is not a problem in build or test, since build.env always overwrites
$VTROOT
and sets it to$PWD
. But it is a problem in the examples/ since there are scripts which will attempt to include$VTROOT/web/vtctld
. My hope is that we can fix this in #5502 before release, so that$VTROOT
is not a run-time requirement at all.Documentation
The changes to the build guides will be documented in vitessio/website#372