Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge VTTOP and VTROOT variables, setting VTROOT to what was VTTOP #5382

Closed
wants to merge 31 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
f92d45a
WIP
morgo Oct 30, 2019
dbeffa0
Revert change of docker working dir
morgo Oct 30, 2019
77baf22
Merge remote-tracking branch 'upstream/master' into morgo-remove-vttop
morgo Nov 5, 2019
1ffe423
Test CI
morgo Nov 6, 2019
96c3ece
Test ci with re-sourcing dev.env file
morgo Nov 6, 2019
d4a2e83
test with destroy local and then link
morgo Nov 6, 2019
eb5b8da
Attempt to fix vtroot
morgo Nov 6, 2019
79ad6c1
Attempt to fix vtroot
morgo Nov 6, 2019
a050c5a
Merge branch 'morgo-remove-vttop' of github.com:planetscale/vitess in…
morgo Nov 6, 2019
88f79bf
Merge remote-tracking branch 'upstream/master' into morgo-remove-vttop
morgo Nov 29, 2019
a897c17
Add make tools
morgo Dec 1, 2019
f90cc82
Make 'make test' work
morgo Dec 1, 2019
78bd499
Merge remote-tracking branch 'upstream/master' into morgo-remove-vttop
morgo Dec 2, 2019
9f5861a
Attempt unit test in new build style
morgo Dec 2, 2019
abf6492
Simplify docker/test/run.sh
morgo Dec 3, 2019
2f04bd8
Turn caching off again
morgo Dec 3, 2019
1df5999
Change bootstrap to always run
morgo Dec 5, 2019
f8a0b6d
Updated detection of old bootstrap
morgo Dec 5, 2019
c94430b
revert travis config
morgo Dec 5, 2019
d38fe11
Merge remote-tracking branch 'upstream/master' into morgo-remove-vttop
morgo Dec 5, 2019
170f8c1
Add symlinks
morgo Dec 6, 2019
ff17696
Fix PATH
morgo Dec 6, 2019
7ddd68e
Fix docker test run
morgo Dec 6, 2019
14850f7
Fix docker test run
morgo Dec 6, 2019
cfbc092
Fix maven
morgo Dec 6, 2019
79d79a2
Merge branch 'morgo-remove-vttop' of github.com:planetscale/vitess in…
morgo Dec 6, 2019
da14904
Found it! copying files in that should not have
morgo Dec 6, 2019
dd62182
Modify append_cmd to be ; instead of &&
morgo Dec 6, 2019
22822e5
move prepared statements to 5, restore &&
morgo Dec 6, 2019
1ac0e52
Fix small bug in re-bootstrap case.
morgo Dec 7, 2019
568b614
Fix check if maven needs installing
morgo Dec 7, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
175 changes: 0 additions & 175 deletions .github/bootstrap.sh

This file was deleted.

9 changes: 3 additions & 6 deletions .github/workflows/check_make_parser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,11 @@ jobs:
sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld
go mod download

- name: Run bootstrap.sh
- name: Run make minimaltools
run: |
echo "Copying new bootstrap over location of legacy one."
cp .github/bootstrap.sh .
./bootstrap.sh
make minimaltools

- name: check_make_parser
run: |
export PATH=$PWD/bin:$PATH
VTDATAROOT=/tmp/vtdataroot VTTOP=$PWD VTROOT=$PWD tools/check_make_parser.sh
tools/check_make_parser.sh

14 changes: 3 additions & 11 deletions .github/workflows/cluster_endtoend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,10 @@ jobs:
sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld
go mod download

- name: Run bootstrap.sh
- name: Run make minimaltools
run: |
echo "Copying new bootstrap over location of legacy one."
cp .github/bootstrap.sh .
./bootstrap.sh

- name: Build
run: |
VTROOT=$PWD VTTOP=$PWD make build
make minimaltools

- name: cluster_endtoend
run: |
export PATH=$PWD/bin:$PATH
source ./dev.env
VTDATAROOT=/tmp/vtdataroot VTTOP=$PWD VTROOT=$PWD make e2e_test_cluster
make e2e_test_cluster
14 changes: 3 additions & 11 deletions .github/workflows/e2e_race.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,10 @@ jobs:
sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld
go mod download

- name: Run bootstrap.sh
- name: Run make minimaltools
run: |
echo "Copying new bootstrap over location of legacy one."
cp .github/bootstrap.sh .
./bootstrap.sh

- name: Build
run: |
VTROOT=$PWD VTTOP=$PWD make build
make minimaltools

- name: e2e_race
run: |
export PATH=$PWD/bin:$PATH
source ./dev.env
VTDATAROOT=/tmp/vtdataroot VTTOP=$PWD VTROOT=$PWD make e2e_test_race
make e2e_test_race
13 changes: 4 additions & 9 deletions .github/workflows/endtoend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,14 @@ jobs:
sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld
go mod download

- name: Run bootstrap.sh
- name: Run make minimaltools
run: |
echo "Copying new bootstrap over location of legacy one."
cp .github/bootstrap.sh .
./bootstrap.sh
make minimaltools

- name: Build
run: |
VTROOT=$PWD VTTOP=$PWD make build
make build

- name: endtoend
run: |
export PATH=$PWD/bin:$PATH
source ./dev.env
mkdir -p /tmp/vtdataroot
VTDATAROOT=/tmp/vtdataroot VTTOP=$PWD VTROOT=$PWD tools/e2e_test_runner.sh
tools/e2e_test_runner.sh
11 changes: 4 additions & 7 deletions .github/workflows/local_example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,15 @@ jobs:
sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld
go mod download

- name: Run bootstrap.sh
- name: Run make minimaltools
run: |
echo "Copying new bootstrap over location of legacy one."
cp .github/bootstrap.sh .
./bootstrap.sh
make minimaltools

- name: Build
run: |
VTROOT=$PWD VTTOP=$PWD make build
make build

- name: local_example
run: |
export PATH=$PWD/bin:$PATH
VTDATAROOT=/tmp/vtdataroot VTTOP=$PWD VTROOT=$PWD test/local_example.sh
test/local_example.sh

13 changes: 3 additions & 10 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,10 @@ jobs:
sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld
go mod download

- name: Run bootstrap.sh
- name: Run make tools
run: |
VTTOP=$PWD VTROOT=$PWD BUILD_PYTHON=0 ./bootstrap.sh

- name: Build
run: |
VTROOT=$PWD VTTOP=$PWD make build
make tools

- name: unit
run: |
export PATH=$PWD/bin:$PATH
source ./dev.env
mkdir -p /tmp/vtdataroot
VTDATAROOT=/tmp/vtdataroot VTTOP=$PWD VTROOT=$PWD tools/unit_test_runner.sh
make test
12 changes: 3 additions & 9 deletions .github/workflows/unit_race.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,10 @@ jobs:
sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld
go mod download

- name: Run bootstrap.sh
- name: Run make tools
run: |
VTTOP=$PWD VTROOT=$PWD BUILD_PYTHON=0 ./bootstrap.sh

- name: Build
run: |
VTROOT=$PWD VTTOP=$PWD make build
make tools

- name: unit_race
run: |
export PATH=$PWD/bin:$PATH
source ./dev.env
VTDATAROOT=/tmp/vtdataroot VTTOP=$PWD VTROOT=$PWD make unit_test_race
make unit_test_race
7 changes: 7 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,10 @@ releases

# Vagrant
.vagrant

dist/*
py-vtdb*
vthook*
bin*

vtdataroot*
Loading