Silence nil value warning in helm3 #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Tocker <[email protected]>
dkhenry
reviewed
Nov 29, 2019
| @@ -33,43 +33,43 @@ config: | |||
|
|
|||
| # choose a backup service - valid values are gcs/s3 | |||
| # TODO: add file and ceph support | |||
| # backup_storage_implementation: gcs | |||
There was a problem hiding this comment.
This is going to change the default behavior to be gcs by default. I would prefer if by default we just didn't configure backups.
dkhenry
approved these changes
Nov 29, 2019
systay
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5464
Helm 3 complained when these values were commented out.
It works now, with only a warning:
I am going to propose we update the website with an interim fix: vitessio/website#368 -- I will then look at Kubernetes 1.16, which looks like more work.
Signed-off-by: Morgan Tocker [email protected]