Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interim helm update #368

Merged
merged 4 commits into from
Jan 7, 2020
Merged

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Nov 28, 2019

I have managed to get helm 3.0 to work, with some small changes I will add in a PR soon.

Kubernetes 1.16 looks like it might be a little bit of work, so I will add a note for now.

@derekperkins
Copy link
Member

I think this might be a little misleading because you can't install the etcd-operator with helm 3 yet. I spent 30 minutes at the Vitess station trying to get things working with a guy from Digital Ocean before that was the final stopping point.
helm/charts#19008

@morgo
Copy link
Contributor Author

morgo commented Nov 28, 2019

I think this might be a little misleading because you can't install the etcd-operator with helm 3 yet. I spent 30 minutes at the Vitess station trying to get things working with a guy from Digital Ocean before that was the final stopping point.
helm/charts#19008

Hmm.. I thought I got it to work with helm 3. I'll have to take another look.

@derekperkins
Copy link
Member

IIUC, the installation works, but it uses a helm 2 hook to create the CRDs themselves. If you already had the definitions themselves, the rest would have worked.

@derekperkins
Copy link
Member

What would be ideal for the getting started guide would be to use the Kubernetes apii server as the topo server. @carsonoid started on an implementation but didn't finish it. I think one of the biggest questions is how much it might bloat the binary to include the k8s client.
https://github.com/carsonoid/vitess/tree/kubernetestopo

@carsonoid
Copy link
Contributor

I was just thinking about the K8s topo server implementation today. I would love to get a chance to complete it.

Suggest helm 3.0 but not k8s 1.16

Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
@morgo
Copy link
Contributor Author

morgo commented Jan 7, 2020

@derekperkins PTAL again

* Install the MySQL client. On Ubuntu: `apt-get install mysql-client`
* Install vtctlclient
4. Install the MySQL client locally. For example, on Ubuntu: `apt-get install mysql-client`
5. Install vtctlclient locally:
* Install go 1.12+
* `go get vitess.io/vitess/go/cmd/vtctlclient`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this start to break with go modules? For the future, we should provide a download link to the latest versioned release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still worked for me, but maybe not the smartest way to do things. I will change it once we publish the new (smaller) package format.

@derekperkins
Copy link
Member

LGTM

@morgo morgo merged commit 0f14512 into vitessio:prod Jan 7, 2020
@morgo morgo deleted the morgo-interim-helm-update branch January 7, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants