Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 support for the Tanzu CLI #4

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

marckhouzam
Copy link
Contributor

This PR takes into consideration the architecture of the machine and installs the Tanzu CLI in ARM64 format on Mac.

Two thing to note:

  1. the Tanzu CLI only started supporting darwin ARM64 starting with version 1.1.0, so this PR adds special handling to use AMD64 before version 1.1.0
  2. Currently the Linux ARM64 format of the Tanzu CLI is not supported, so this PR adds it to MISSING_PRODUCTS.

The changes are backwards-compatible for the other tools supported by this repo.

This PR does not enable ARM64 for the other tools but another PR could easily be done to check which such tools provides such binaries and modify the code to handle this.

Copy link
Contributor

@laidbackware laidbackware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laidbackware laidbackware merged commit f02631b into vmware-tanzu:main Jun 28, 2024
37 checks passed
@marckhouzam marckhouzam deleted the feat/arm64TanzuCLI branch June 29, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants