-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge into main #2282
Merged
Merge into main #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix view expression sort documentation
…beled (#2145) * fix some samples are annotated * full result information for all samples * update ls_type and ids values Co-authored-by: Eric Hofesmann <[email protected]> Co-authored-by: Eric Hofesmann <[email protected]>
Adding support for dynamic embedded document field schemas
Adding support for field descriptions
Field desc fixups
Fix typo in get_dataloader
* adding support for configuring the App's default theme via the app config * oops * wrong type * theme enum * add data flow * browser storage setting Co-authored-by: Benjamin Kane <[email protected]>
* update color scheme on theme update * layout effect * clean Co-authored-by: Benjamin Kane <[email protected]>
* work * embed refactor * refactor for embed * fix app loading for embed * add viewbar to dataset component * fix plugin loading for embed * fix embed layout css * fix non-embed regression * fix built in plugins * export css from dataset component * add path prefix override for embed * use path prefix for events route * fixes for nextjs build * fix media path * fix getSampleSrc url detection * initial theme pass * tweaks * edits * server updates * aggregation work * bugs, integrating * bugs * cleaning * update dataset loader * cleaning * bugs * withSuspense for filters * bug * update useTagText * bugs * video bugs * sidebar mode and groups work * work * persisted expanded group setting, sidebar mode details * fix * theme tweaks * fix * wrap dataset container with ThemeContext when a theme prop is provided * fix * tweaks * compiled aggregations setup * bugs, documenting * passing agg tests * optimized server aggs * cleanup * adding method to generate default sidebar groups * fix * slow to all * conditional sidebar tags * fix * schema * only generate default sidebar groups * don't populate expanded by default * linting * simplifying * fix * documenting sidebar mode and sidebar groups * tweaks * adding v0.18 release notes * tweaks * more docs links * cleanup * loading animation * bugs, tweaks * normalizing * tweaks * handling None field * fix toggle, reset sidebar mode * persist sidebar groups * tweaks * fix * handling mongoengine types * fix calls * adding missing context arg * include all non-nested roots * context tweak * fixing naming * prevent nested facet aggregations when compiling * fixing schemas * linting * loading state fixes * bug * linting * bug * linting * updating sidebar_mode documentation * removing multiple definitions of expanded * adding sidebar stuff to migration * fix serialization * refresh after tagging * various fixes * cleaning up * adding sidebar GIFs * bumping brain version * adding support for serializing Schema() aggregations * adding support for serializing faceted aggregations * explaining * bumping release date * fix patching * fixes * Final fixups (#2254) * handling None field * fix toggle error when click start event is unset * increase field tooltip delay * fix field info tooltip colors * fix looker loading and background in flashlight for light mode * updating lock * remove stray logs * fix field info light borders * fixing mongoengine bug * fix weird sidebar field click behavior * fix sidebar toggle to update on clicking checkbox * fix flashlight tile background Co-authored-by: brimoor <[email protected]> Co-authored-by: imanjra <[email protected]> Co-authored-by: Brian Moore <[email protected]> * regression * re-enable field text selection * query sidebar groups * show tags in fast mode * don't allow app_config to be nulled * await bug * persist in app sidebar group expansion across views * fix * proper handling of excluded fields * fixing faceted aggregation regression * confirmed that pathing is already handled * fixes * expanded field count * updating docs * root field counts * iss 2255 * fixing bug * reset group statistics * groups and dist fixes * bump db * rm test pypi * rm test pypi * bump desktop * resolving merge conflict * linting * update color scheme on theme update * omitting fiftyone/server * tweak * layout effect * clean * db bump * transparent looker * adjust background * tweaks Co-authored-by: Ritchie Martori <[email protected]> Co-authored-by: imanjra <[email protected]> Co-authored-by: brimoor <[email protected]> Co-authored-by: Brian Moore <[email protected]>
Strawberry kwargs
Documenting app config resets
Sidebar resets
Removed extra title
* url and unsupported tweaks * refresh bug * use other, not unsupported * improve sidebar settings * subfield list field check * bug * bugs * fix logic * loading dots * we do need to split path here * dots are animated now * bug * always be debugging * bump desktop Co-authored-by: brimoor <[email protected]>
brimoor
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.