Include coinciding filters in sidebar search results #3973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.5 #3973 +/- ##
==================================================
Coverage ? 15.99%
==================================================
Files ? 732
Lines ? 82062
Branches ? 1110
==================================================
Hits ? 13123
Misses ? 68939
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
benjaminpkane
added
enhancement
|
@benjaminpkane Was testing this and noticed one odd aspect. See this screencast around 0:42. The count for the second selection (drop-down in "search mode") shows 0. This also occurs when this prodID selection is made initially. Screenshare.-.2024-01-15.6_03_17.PM.mp4 |
|
Ok I see the issue. Will adjust |
allenleetc
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Tested functionally. Very cool thanks @benjaminpkane
Screenshare.-.2024-02-05.9_42_07.AM.mp4
|
Thanks @allenleetc 🙏 Undrafting |
sashankaryal
approved these changes
Feb 8, 2024
Comment on lines
+25
to
+27
| delete filters[path]; | ||
|
|
||
| return filters; |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds coinciding filters to search results in the sidebar (not applicable to lightning filters)
Before
Screen.Recording.2024-01-05.at.10.20.40.AM.mov
After
Screen.Recording.2024-01-05.at.10.19.54.AM.mov