-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indexed BooleanFields in Lightning Mode #4139
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.7 #4139 +/- ##
==================================================
Coverage ? 16.01%
==================================================
Files ? 734
Lines ? 82219
Branches ? 1119
==================================================
Hits ? 13166
Misses ? 69053
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like this will require a Teams release to go along with the OSS release. That hasn't been set up or planned.
This should probably be targetted for the 3/20 Teams 1.5.8 / OSS 0.23.8 release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
What changes are proposed in this pull request?
Fixes a regression introduced by #3973 where indexed
BooleanField
s will throw an error in thepathSearchResults
selectorHow is this patch tested? If it is not, please explain why.
Opening the filter currently raises an error (see recording)
Screen.Recording.2024-03-07.at.4.11.25.PM.mov
Release Notes
What areas of FiftyOne does this PR affect?
fiftyone
Python library changes