Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexed BooleanFields in Lightning Mode #4139

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

benjaminpkane
Copy link
Contributor

What changes are proposed in this pull request?

Fixes a regression introduced by #3973 where indexed BooleanFields will throw an error in the pathSearchResults selector

How is this patch tested? If it is not, please explain why.

import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart", max_samples=1)
dataset.create_index("$**")
sample = dataset.first()
sample["bool"] = True
sample.save()

Opening the filter currently raises an error (see recording)

Screen.Recording.2024-03-07.at.4.11.25.PM.mov

Release Notes

  • Fix indexed BooleanFields in Lightning Mode

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features labels Mar 7, 2024
@benjaminpkane benjaminpkane self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/v0.23.7@cf23db0). Click here to learn what that means.

Files Patch % Lines
...src/components/Filters/StringFilter/Checkboxes.tsx 0.00% 3 Missing ⚠️
...ages/state/src/recoil/pathData/lightningBoolean.ts 0.00% 3 Missing ⚠️
...kages/state/src/recoil/pathData/lightningString.ts 0.00% 3 Missing ⚠️
app/packages/state/src/recoil/pathData/boolean.ts 0.00% 2 Missing ⚠️
...p/packages/core/src/components/Common/Checkbox.tsx 0.00% 1 Missing ⚠️
...ages/state/src/recoil/pathData/lightningNumeric.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v0.23.7    #4139   +/-   ##
==================================================
  Coverage                   ?   16.01%           
==================================================
  Files                      ?      734           
  Lines                      ?    82219           
  Branches                   ?     1119           
==================================================
  Hits                       ?    13166           
  Misses                     ?    69053           
  Partials                   ?        0           
Flag Coverage Δ
app 16.01% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@findtopher findtopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like this will require a Teams release to go along with the OSS release. That hasn't been set up or planned.

This should probably be targetted for the 3/20 Teams 1.5.8 / OSS 0.23.8 release

Copy link
Contributor

@kaixi-wang kaixi-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@brimoor brimoor merged commit 44bfca6 into release/v0.23.7 Mar 16, 2024
13 checks passed
@brimoor brimoor deleted the bug/bool-lightning branch March 16, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Issues related to App features bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants