Fix indexed BooleanFields in Lightning Mode

app/packages/core/src/components/Common/Checkbox.tsx

@@ -2,7 +2,7 @@ import { LoadingDots, useTheme } from "@fiftyone/components";
 import { Checkbox as MaterialCheckbox } from "@mui/material";
 import { animated } from "@react-spring/web";
 import React, { useMemo } from "react";
-import { constSelector, RecoilValueReadOnly } from "recoil";
+import { RecoilValueReadOnly, constSelector } from "recoil";
 import styled from "styled-components";
 import { prettify } from "../../utils/generic";
 import { ItemAction } from "../Actions/ItemAction";

app/packages/core/src/components/Filters/StringFilter/Checkboxes.tsx

@@ -161,6 +161,7 @@ const Checkboxes = ({
 
   const show = useRecoilValue(showSearchSelector({ modal, path }));
   const keypoints = useRecoilValue(isInKeypointsField(path));
+  const lightning = useRecoilValue(fos.isLightningPath(path));
 
   if (loading) {
     return <LoadingDots text={"Loading"} />;
@@ -186,7 +187,8 @@ const Checkboxes = ({
             name={value === null ? "None" : value}
             loading={loading}
             count={
-              typeof count !== "number" || !isFilterMode || keypoints
+              (typeof count !== "number" || !isFilterMode || keypoints) &&
+              !lightning
                 ? // only string and id fields use pathSearchCount
                   pathSearchCount({ modal, path, value: value as string })
                 : count

app/packages/state/src/recoil/pathData/boolean.ts

@@ -1,7 +1,6 @@
 import { selectorFamily } from "recoil";
 import { aggregation } from "../aggregations";
 import { isLightningPath, lightning } from "../lightning";
-import { noneCount } from "./counts";
 import { lightningBooleanResults } from "./lightningBoolean";
 
 export const booleanResults = selectorFamily<
@@ -19,7 +18,7 @@ export const booleanResults = selectorFamily<
         return get(lightningBooleanResults(params));
       }
 
-      return booleanCountResults(params);
+      return get(booleanCountResults(params));
     },
 });
 
@@ -29,7 +28,6 @@ export const booleanCountResults = selectorFamily({
     (params: { path: string; modal: boolean; extended: boolean }) =>
     ({ get }) => {
       const data = get(aggregation(params));
-      const none = get(noneCount(params));
 
       if (data.__typename !== "BooleanAggregation") {
         throw new Error("unexpected");
@@ -42,9 +40,7 @@ export const booleanCountResults = selectorFamily({
           { value: "True", count: data.true },
         ].filter(({ count }) => count),
       };
-      if (none) {
-        result.results.push({ value: null, count: none });
-      }
+
       return result;
     },
 });

app/packages/state/src/recoil/pathData/lightningBoolean.ts

@@ -15,7 +15,9 @@ export const lightningBooleanResults = selectorFamily<
       const [data] = get(lightningQuery([{ path: params.path }]));
 
       if (data.__typename !== "BooleanLightningResult") {
-        throw new Error("unexpected");
+        throw new Error(
+          `unexpected ${data.__typename} for path '${params.path}' in lightningBooleanResults`
+        );
       }
 
       return {

app/packages/state/src/recoil/pathData/lightningNumeric.ts

@@ -34,7 +34,7 @@ export const lightningNumericResults = selectorFamily({
       }
 
       throw new Error(
-        `unexpected type '${data.__typename}' for path '${path}'`
+        `unexpected ${data.__typename} for path '${path}' in lightningNumericResults`
       );
     },
 });

app/packages/state/src/recoil/pathData/lightningString.ts

@@ -12,7 +12,9 @@ export const lightningStringResults = selectorFamily<
       const [data] = get(lightningQuery([params]));
 
       if (data.__typename !== "StringLightningResult") {
-        throw new Error("bad");
+        throw new Error(
+          `unexpected ${data.__typename} for path '${params.path}' in lightningStringResults`
+        );
       }
 
       if (!data.values) {