Add CentOS support to fiftyone-db

[benjaminpkane]

What changes are proposed in this pull request?

Add CentOS entries to the fiftyone-db package. CentOS uses the same downloads as RHEL. See MongoDB downloads for confirmation

Resolves #4427

How is this patch tested? If it is not, please explain why.

Using CentOS

pip install fiftyone-db==1.1.3rc1

What areas of FiftyOne does this PR affect?

• App: FiftyOne application changes
• Build: Build and test infrastructure changes
• Core: Core fiftyone Python library changes
• Documentation: FiftyOne documentation changes
• Other

Summary by CodeRabbit

• New Features

  • Added MongoDB download links for CentOS 7, 8, and 9 for various architectures.
  • Included an additional MongoDB download link for Windows with the "amd64" architecture.

• Updates

  • Updated MongoDB download links for Debian 9.
  • Updated version from "1.1.1" to "1.1.3".

• CI/CD

  • Added a conditional step for uploading a wheel artifact based on the platform in the build workflow.

[coderabbitai]

Walkthrough

The changes introduce a new step in the GitHub Actions workflow to upload a wheel artifact conditionally based on the platform. Additionally, the setup.py script for the package/db has been updated to include MongoDB download links for CentOS 7, 8, and 9, updated links for Debian 9, and an additional link for Windows (amd64). The version has also been incremented to 1.1.3.

Changes

File	Change Summary
.github/workflows/build-db.yml	Added a conditional step for uploading a wheel artifact based on the platform being different from 'sdist'.
package/db/setup.py	Added MongoDB download links for CentOS 7, 8, and 9, updated Debian 9 links, added a Windows (amd64) link, and incremented the version to 1.1.3.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
[#4427] Ensure MongoDB can be installed on CentOS 7	✅
[#4427] Add MongoDB download links for CentOS 8 and 9, and update Debian 9 links	✅
[#4427] Increment version to reflect changes	✅

Poem

In the code, a change so bright,
MongoDB links take flight,
CentOS, Debian, Windows too,
Now the setup's fresh and new.
FiftyOne, without a hitch,
On platforms, it will swiftly stitch.
Version up, the future's clear,
With every fix, we hold it dear.

Warning

Review ran into problems

Problems (1)

• Git: Failed to clone repository. Please contact CodeRabbit support.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[findtopher]

👍

...once you have your conflicts resolved...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.00%. Comparing base (1688ce2) to head (ec57f0d).
Report is 1031 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #4437       +/-   ##
===========================================
- Coverage   28.84%   16.00%   -12.84%     
===========================================
  Files         768      807       +39     
  Lines       97032    89611     -7421     
  Branches     1120     1345      +225     
===========================================
- Hits        27988    14345    -13643     
- Misses      69044    75266     +6222     

Flag	Coverage Δ
app	16.00% <ø> (-0.02%)	⬇️
python	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ef5635e and ec57f0d.

Files selected for processing (2)

• .github/workflows/build-db.yml (1 hunks)
• package/db/setup.py (4 hunks)

Files skipped from review due to trivial changes (1)

• .github/workflows/build-db.yml

Additional comments not posted (3)

package/db/setup.py (3)

40-52: Added CentOS support for MongoDB downloads.

The addition of CentOS download links for MongoDB versions across various architectures aligns with the PR's objective to support CentOS. Ensure that these URLs are kept up-to-date with MongoDB's official releases to avoid future issues.

---

130-130: Consider handling case sensitivity for machine types in Windows.

Converting the machine type to lowercase before fetching the download link is a good practice to avoid case sensitivity issues. This change enhances the robustness of the download mechanism.

---

142-142: Version update to "1.1.3".

The version update from "1.1.1" to "1.1.3" is noted and aligns with the changes made in this update, including the support for new operating systems and architectures.

[coderabbitai]

Ensure consistency in Windows download links.

The download links for "x86_64" and "amd64" are identical. If these architectures are indeed the same, consider removing one to avoid redundancy and potential confusion.