-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fedora support to fiftyone-db #4866
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 177 files out of 260 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the WalkthroughThe changes introduce a new mapping for Fedora in the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
package/db/setup.py (1)
Line range hint
1-324
: Consider adding Fedora-specific tests or verification stepsThe changes made to add Fedora support look good overall. To further improve the robustness of the Fedora support, consider the following suggestions for future updates:
- Add a test case or verification step specifically for Fedora in your CI/CD pipeline or testing suite.
- Document the Fedora support in the project's README or documentation.
- Consider adding a Fedora-specific section in the
CustomBdistWheel
class if any special handling is required for Fedora distributions.These suggestions are not critical for the current PR but could enhance the long-term maintainability and reliability of the Fedora support.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- package/db/setup.py (2 hunks)
🔇 Additional comments (1)
package/db/setup.py (1)
174-174
: LGTM: Version updateThe version bump from 1.1.5 to 1.1.6 is appropriate for the addition of Fedora support. It follows semantic versioning principles by incrementing the patch version for a backwards-compatible feature addition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, why not!
What changes are proposed in this pull request?
Add Fedora support to
fiftyone-db
How is this patch tested? If it is not, please explain why.
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit
New Features
aarch64
andx86_64
architectures.Updates
1.1.5
to1.1.6
.