Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora support to fiftyone-db #4866

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Conversation

benjaminpkane
Copy link
Contributor

@benjaminpkane benjaminpkane commented Sep 30, 2024

What changes are proposed in this pull request?

Add Fedora support to fiftyone-db

How is this patch tested? If it is not, please explain why.

docker pull fedora:40
docker run -it fedora:40

# in container
yum install wget
wget https://fastdl.mongodb.org/linux/mongodb-linux-aarch64-rhel90-7.0.2.tgz
tar -xvzf mongodb-linux-aarch64-rhel90-7.0.2.tgz
cd mongodb-linux-aarch64-rhel90-7.0.2/bin
./mongod --version # RHEL works for Fedora

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • New Features

    • Added support for Fedora version 4 for both aarch64 and x86_64 architectures.
  • Updates

    • Package version updated from 1.1.5 to 1.1.6.

Copy link
Contributor

coderabbitai bot commented Sep 30, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

177 files out of 260 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes introduce a new mapping for Fedora in the LINUX_DOWNLOADS dictionary, specifically for version 4 and both aarch64 and x86_64 architectures. The package version is updated from 1.1.5 to 1.1.6, and the _get_download function is modified to accommodate the new Fedora mapping. The get_version function reflects the updated version number, while the CustomBdistWheel class remains unchanged. Overall, the modifications enhance the setup script's capability to support additional Linux distributions.

Changes

Files Change Summary
package/db/setup.py - Added fedora mapping in LINUX_DOWNLOADS for version 4 (aarch64, x86_64)
- Updated version from 1.1.5 to 1.1.6
- Modified _get_download to include the new Fedora mapping
- get_version function updated to reflect new version number
- CustomBdistWheel class and methods unchanged

Possibly related PRs

  • Add CentOS support to fiftyone-db #4437: This PR adds download links for CentOS in the same package/db/setup.py file and modifies the _get_download() function, similar to the changes made for Fedora in the main PR.
  • Add Ubuntu 24.04 fiftyone-db support #4533: This PR updates the VERSION in package/db/setup.py and adds a new dictionary entry for Ubuntu, which is directly related to the version update and structure changes in the main PR.

Suggested reviewers

  • findtopher

Poem

In the garden where code does bloom,
A new Fedora joins the room.
With a hop and a skip, we update our way,
Version 1.1.6 is here to stay!
Let’s celebrate with joy and cheer,
For more downloads, we hold dear! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
package/db/setup.py (1)

Line range hint 1-324: Consider adding Fedora-specific tests or verification steps

The changes made to add Fedora support look good overall. To further improve the robustness of the Fedora support, consider the following suggestions for future updates:

  1. Add a test case or verification step specifically for Fedora in your CI/CD pipeline or testing suite.
  2. Document the Fedora support in the project's README or documentation.
  3. Consider adding a Fedora-specific section in the CustomBdistWheel class if any special handling is required for Fedora distributions.

These suggestions are not critical for the current PR but could enhance the long-term maintainability and reliability of the Fedora support.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 606694a and a69e0bd.

📒 Files selected for processing (1)
  • package/db/setup.py (2 hunks)
🔇 Additional comments (1)
package/db/setup.py (1)

174-174: LGTM: Version update

The version bump from 1.1.5 to 1.1.6 is appropriate for the addition of Fedora support. It follows semantic versioning principles by incrementing the patch version for a backwards-compatible feature addition.

package/db/setup.py Show resolved Hide resolved
@benjaminpkane benjaminpkane requested review from a team as code owners September 30, 2024 14:57
@benjaminpkane benjaminpkane changed the base branch from main to release/v1.0.0 September 30, 2024 14:57
@benjaminpkane benjaminpkane removed the request for review from a team September 30, 2024 15:03
Copy link
Member

@findtopher findtopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, why not!

@benjaminpkane benjaminpkane merged commit 40593bd into release/v1.0.0 Sep 30, 2024
20 checks passed
@benjaminpkane benjaminpkane deleted the chore/db-fedora branch September 30, 2024 17:28
@coderabbitai coderabbitai bot mentioned this pull request Oct 10, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants