Merge pull request #957 from VtG242/patch-1

Fix `ignoreselected` typo in protocols.conf.erb template

manifests/plugin/protocols.pp

@@ -1,8 +1,8 @@
 # See http://collectd.org/documentation/manpages/collectd.conf.5.shtml#plugin_protocols
 class collectd::plugin::protocols (
-  $ensure                 = 'present',
-  Boolean $ignoreselected = false,
-  Array $values           = []
+  $ensure = 'present',
+  Optional[Boolean] $ignoreselected = undef,
+  Array $values = []
 ) {
   include collectd
 

spec/classes/collectd_plugin_protocols_spec.rb

@@ -32,6 +32,30 @@
         end
       end
 
+      describe 'ignoreselected' do
+        context ':ignoreselected => false' do
+          let :params do
+            {
+              values: %w[protocol1 protocol2],
+              ignoreselected: false
+            }
+          end
+
+          it { is_expected.to contain_file('protocols.load').with_content(%r{<Plugin "protocols">\n\s*Value "protocol1"\n\s*Value "protocol2"\n\s*IgnoreSelected false\n</Plugin>}) }
+        end
+
+        context ':ignoreselected => true' do
+          let :params do
+            {
+              values: %w[protocol1 protocol2],
+              ignoreselected: true
+            }
+          end
+
+          it { is_expected.to contain_file('protocols.load').with_content(%r{<Plugin "protocols">\n\s*Value "protocol1"\n\s*Value "protocol2"\n\s*IgnoreSelected true\n</Plugin>}) }
+        end
+      end
+
       context ':ensure => absent' do
         let :params do
           { ensure: 'absent' }

templates/plugin/protocols.conf.erb

@@ -1,16 +1,16 @@
 <% if @values -%>
 <Plugin "protocols">
-<% 
+<%
 if @values
-  @values.each do |value| 
+  @values.each do |value|
 -%>
   Value "<%= value %>"
 <%
   end
 end
 -%>
-<% if @ignore_selected != nil -%>
-  IgnoreSelected <%= @ignore_selected %>
+<% unless @ignoreselected == nil -%>
+  IgnoreSelected <%= @ignoreselected %>
 <% end -%>
 </Plugin>
 <% end -%>