Fix ignoreselected typo in protocols.conf.erb template
#957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
approved these changes
Sep 24, 2020
|
why are unit Tests failing on puppet 5 & 6? |
alexjfisher
reviewed
Sep 25, 2020
templates/plugin/protocols.conf.erb
Outdated
| @@ -9,8 +9,8 @@ if @values | |||
| end | |||
| end | |||
| -%> | |||
| <% if @ignore_selected != nil -%> | |||
| IgnoreSelected <%= @ignore_selected %> | |||
| <% if @ignoreselected != nil -%> | |||
There was a problem hiding this comment.
Currently, ignoreselected is a Boolean. That means it can never be nil (undef in puppet).
There was a problem hiding this comment.
Looks like it was always a boolean and never defaulted to undef.
I've also made the default for `ignoreselected` `undef`. Up until now, this parameter *never* worked. By making the default `undef` (instead of `false`), the majority of users will not see any change to their config files and the collectd service won't get restarted.
alexjfisher
force-pushed
the
patch-1
branch
from
ea11c42
to
03c2c23
Compare
bastelfreak
approved these changes
Sep 25, 2020
alexjfisher
changed the title
ignoreselected typo in protocols.conf.erb template
|
@VtG242 Thanks for the bugfix! I've made the existing test pass by changing the default to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description