Add merge facts option to add_custom_fact #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
feat-add_merge_facts
branch
2 times, most recently
from
57b22e2
to
97ce604
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 95.23% 95.34% +0.11%
==========================================
Files 2 2
Lines 168 172 +4
==========================================
+ Hits 160 164 +4
Misses 8 8 ☔ View full report in Codecov by Sentry. |
jordanbreen28
force-pushed
the
feat-add_merge_facts
branch
3 times, most recently
from
6a9fdf3
to
b8517d3
Compare
jordanbreen28
force-pushed
the
feat-add_merge_facts
branch
2 times, most recently
from
b3be6bc
to
49673bf
Compare
This commit adds an option to the add_custom_fact method, which allows the user to specify whether they wish to deep_merge facts. This allows the user to determine whether they wish to completely overwrite a fact, or simply merge values into the existing fact in a given fact hash.
jordanbreen28
force-pushed
the
feat-add_merge_facts
branch
from
49673bf
to
d0c9451
Compare
|
@ekohl @bastelfreak 👋 sorry for the ping.. Does this need anything/any comments? Thanks |
bastelfreak
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
looks good to me, but I would like to have a review from @ekohl as well.
h0tw1r3
approved these changes
Feb 14, 2024
bastelfreak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new merge_facts option, which can be used with the add_custom_fact method in your configurations.
It allows users to determine whether they want to completely overwrite a fact already present in the facts hash, or simply merge values into the existing fact to expand/overwrite certain values whilst the entirety of the fact.
sample usage:
add_custom_fact :identity, { 'user' => "test_user" }, merge_facts: true
will update the value of user in the identity fact to "test_user", whilst keeping the rest of the identity fact values the same.
Failing tests rely on the merge of #157