Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: move forceSoap12Headers to IWsdlBaseOptions #1063

Merged

Conversation

peat-psuwit
Copy link
Contributor

"forceSoap12Headers" works on server since bcc41e6. So, this option
should be available to server as well.

"forceSoap12Headers" works on server since bcc41e6. So, this option
should be available to server as well.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.284% when pulling a107b5f on peat-psuwit:move-forceSoap12Headers-to-IWsdlBaseOptions into 2f033b1 on vpulim:master.

@jsdevel jsdevel merged commit 920144a into vpulim:master Apr 29, 2019
@jsdevel
Copy link
Collaborator

jsdevel commented Apr 29, 2019

thanks!

lfantone pushed a commit to flybondi/node-soap that referenced this pull request May 20, 2019
* Fixed some issues with xsd elements (vpulim#1057)

* Fixed some issues with xsd elements

* Made the fix more specific to the particular usecase

* Added a test for aliased namespaces

* Release v0.27.0

* Move @types/request to dependencies (vpulim#1059)

soap's d.ts files depend on request. Unfortunately, since request
doesn't ship its own types, that means consumers of soap also need
@types/request. Currently @types/request is just a dev dependency, which
doesn't get installed by `npm install`. The fix is to move
`@types/request` to the dependencies list.

The error looks like this:

```
node_modules/soap/lib/client.d.ts(4,26): error TS7016: Could not find a declaration file for module 'request'. '../../../tests/cases/user/soap/node_modules/request/index.js' implicitly has an 'any' type.
```

Note that this only shows up when consumers compile with --strict, which is
fairly common.  Typescript's user-code tests include soap and detected
it after 0.27 shipped.

* Release v0.27.1

* Updated read me to reflect changes in soap.listen (vpulim#1060)

* Updated Read.me to reflect changes in soap.listen

* Updated Readme.md

* Updated Readme.md

* Updated Readme.md

* types: move forceSoap12Headers to IWsdlBaseOptions (vpulim#1063)

"forceSoap12Headers" works on server since bcc41e6. So, this option
should be available to server as well.

* client.addSoapHeader() dynamic SOAP header (vpulim#1062)

* Added support for parsing of doubles and floats. (vpulim#1065)

* Added support for parsing of doubles and floats.
package-lock updated due to out-of-date version.

* Reverting changed package-lock file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants