Added support for parsing of doubles and floats. #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package-lock updated due to out-of-date version.
|
please revert package-lock.json. we'll update it. |
Done, thanks a lot @jsdevel |
|
I'm a little confused as to why Travis failed for Node v9 and v7, is that a known issue? |
|
If it helps the build passes on my branch so guess it was an intermittent test timeout? See: https://travis-ci.org/alexb-uk/node-soap/builds/531663881 |
|
thanks @alexb-uk ! |
lfantone
pushed a commit
to flybondi/node-soap
that referenced
this pull request
May 20, 2019
* Fixed some issues with xsd elements (vpulim#1057) * Fixed some issues with xsd elements * Made the fix more specific to the particular usecase * Added a test for aliased namespaces * Release v0.27.0 * Move @types/request to dependencies (vpulim#1059) soap's d.ts files depend on request. Unfortunately, since request doesn't ship its own types, that means consumers of soap also need @types/request. Currently @types/request is just a dev dependency, which doesn't get installed by `npm install`. The fix is to move `@types/request` to the dependencies list. The error looks like this: ``` node_modules/soap/lib/client.d.ts(4,26): error TS7016: Could not find a declaration file for module 'request'. '../../../tests/cases/user/soap/node_modules/request/index.js' implicitly has an 'any' type. ``` Note that this only shows up when consumers compile with --strict, which is fairly common. Typescript's user-code tests include soap and detected it after 0.27 shipped. * Release v0.27.1 * Updated read me to reflect changes in soap.listen (vpulim#1060) * Updated Read.me to reflect changes in soap.listen * Updated Readme.md * Updated Readme.md * Updated Readme.md * types: move forceSoap12Headers to IWsdlBaseOptions (vpulim#1063) "forceSoap12Headers" works on server since bcc41e6. So, this option should be available to server as well. * client.addSoapHeader() dynamic SOAP header (vpulim#1062) * Added support for parsing of doubles and floats. (vpulim#1065) * Added support for parsing of doubles and floats. package-lock updated due to out-of-date version. * Reverting changed package-lock file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also package-lock updated due to out-of-date version currently checked into
master.Minor tweak to existing tests to better cover the parsing of double and float.
Background:
After reviewing the existing very old PR that fixes doubles and floats thought best to create a new one with a slightly different approach
See: #985
I've gone for
Number(text)instead ofparseFloat(text)as I think it's safer to throw an error on unexpected characters rather than allowing an assumption.E.g. "1a" !== 1
There is a good explanation of the pro's con's of
Number()vsparseFloat()here: https://stackoverflow.com/questions/12227594/which-is-better-numberx-or-parsefloatx