Added Options object for signer.computeSignature #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XML-crypto vers 1.4.0 broke the WSSecuriityCert functionality Added the optons needed to correctly add the headers
Closed
added 2 commits
May 15, 2019 14:57
Updated the Reademe with options details for WSSecurityCert Reverted the Tests Locked XML-crypto to version ~1.2.0 Reverted the Package-lock.json file Reworked the signerOptions to be park of the WSS options.
|
@LorneCurrie please update your git config so we can properly track you in git history later on. also, please add a test |
|
I'm using version 0.28.0 from node-soap and I'm facing this error. When the fix will be released? |
|
@holmmikael when tests are added. if you'd like to copy this effort and add tests in your own pr feel free, otherwise you'll need to reach out to @LorneCurrie and ask him to add tests. |
|
Sorry, I have been caught up on some things. I'll update the tests this weekend |
Simplied the XML SignerOpetions to only include the attribute that is currently causing the issues Added tests Updated Readme.
|
Tests added |
|
Thank you! |
Danail-Irinkov
pushed a commit
to Danail-Irinkov/node-soap
that referenced
this pull request
Jan 19, 2020
* Added Options object for signer.computeSignature XML-crypto vers 1.4.0 broke the WSSecuriityCert functionality Added the optons needed to correctly add the headers * Fixed a linting issues * Small changes Updated the Reademe with options details for WSSecurityCert Reverted the Tests Locked XML-crypto to version ~1.2.0 Reverted the Package-lock.json file Reworked the signerOptions to be park of the WSS options. * Added tests Simplied the XML SignerOpetions to only include the attribute that is currently causing the issues Added tests Updated Readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locked the XML-Crypto to 1.2.0
updated the readme with details about options for WSSecurityCert function
Added the signer Options to the WSSecurityCerts OPtions to be used in xml-crypto. Helps with a breaking change in 1.4.0. Detail about change below.
XML-crypto 1.4.0, would add the
xmlnsxmlns:wsse=""to the<wsse:SecurityTokenReference xmlns:wsse="">when thesigner.computeSignaturefunction was called.This was different behaviour to the version (1.2.0) locked in the project.
When Node-Soap was imported into my project, the version of XML-crypto that was set using the hat
^would pick the latest minor version release, which had different behaviour.Other option for the fix would be to lock the version fo xml-crypto to 1.2.0 minor range
Pull request: 1067 is another option that would fix this option and is less evasive.
XML before the change:
After the change