Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock xml-crypto #1067

Closed

Conversation

LorneCurrie
Copy link
Contributor

XML crypto version 1.4.0 has a breaking change
Locked version to 1.2.0 as that still works with the current version of node soap

This is a less invasive option to Pull request #1066 I submitted

XML crypto  version 1.4.0 has a breaking change
Locked version to 1.2.0 as that still works with current version
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.33% when pulling f067425 on LorneCurrie:lock-verson-of-xml-soap into f7e2efc on vpulim:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.33% when pulling f067425 on LorneCurrie:lock-verson-of-xml-soap into f7e2efc on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented May 15, 2019

can you revert package-lock.json? we'll update it.

@jsdevel
Copy link
Collaborator

jsdevel commented May 15, 2019

can you add this to #1066 ?

@LorneCurrie
Copy link
Contributor Author

will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants