Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies and refactor code to work with the latest xml-crypto #1242

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

w666
Copy link
Collaborator

@w666 w666 commented Jun 14, 2024

Refactor WSSecurityCert and WSSecurityCertWithToken to make it
work with the latest xml-crypto.

Fix invalid test xml strings in WSSecurityCert and
WSSecurityCertWithToken tests.

Update dependencies:

  • axios to 1.7.2
  • debug to 4.3.5
  • formidable to 3.5.1
  • sax to 1.4.1
  • uuid to 10.0.0
  • whatwg-mimetype to 4.0.0
  • xml-crypto to 6.0.0

Update dev dependencies:

  • @types/debug to 4.1.12
  • @types/express to 4.17.21
  • @types/lodash to 4.17.5
  • @types/node to 14.0.0
  • @types/request to 2.48.12
  • @types/sax to 1.2.7
  • @types/uuid to 9.0.8
  • @types/whatwg-mimetype to 3.0.2
  • body-parser to 1.20.2
  • colors to 1.4.0
  • diff to 5.2.0
  • doctoc to 2.2.1
  • duplexer to 0.1.2
  • express to 4.19.2
  • finalhandler to 1.2.0
  • glob to 10.4.1
  • jshint to 2.13.6
  • mocha to 10.4.0
  • nyc to 17.0.0
  • semver to 7.6.2
  • serve-static to 1.15.0
  • sinon to 18.0.0
  • source-map-support to 0.5.21

…ypto

 Refactor WSSecurityCert and WSSecurityCertWithToken to make it
 work with the latest xml-crypto.

 Fix invalid test xml strings in WSSecurityCert and
 WSSecurityCertWithToken tests.

 Update dependencies:
 - axios to 1.7.2
 - debug to 4.3.5
 - formidable to 3.5.1
 - sax to 1.4.1
 - uuid to 10.0.0
 - whatwg-mimetype to 4.0.0
 - xml-crypto to 6.0.0

 Update dev dependencies:
 - @types/debug to 4.1.12
 - @types/express to 4.17.21
 - @types/lodash to 4.17.5
 - @types/node to 14.0.0
 - @types/request to 2.48.12
 - @types/sax to 1.2.7
 - @types/uuid to 9.0.8
 - @types/whatwg-mimetype to 3.0.2
 - body-parser to 1.20.2
 - colors to 1.4.0
 - diff to 5.2.0
 - doctoc to 2.2.1
 - duplexer to 0.1.2
 - express to 4.19.2
 - finalhandler to 1.2.0
 - glob to 10.4.1
 - jshint to 2.13.6
 - mocha to 10.4.0
 - nyc to 17.0.0
 - semver to 7.6.2
 - serve-static to 1.15.0
 - sinon to 18.0.0
 - source-map-support to 0.5.21
@w666 w666 mentioned this pull request Jun 14, 2024
@vision10
Copy link
Contributor

vision10 commented Jun 14, 2024

request package was removed so you can also remove @types/request

@kouak
Copy link
Contributor

kouak commented Jun 16, 2024

I believe uuid and @types/uuid can be dropped.

Only v4 is used, and can be replaced by randomUUID from node:crypto : https://nodejs.org/docs/latest-v18.x/api/crypto.html#cryptorandomuuidoptions

@w666
Copy link
Collaborator Author

w666 commented Jun 18, 2024

Removed requests and replaced uuid with built-in crypto.randomUUID().

Also run a smoke test against latest node 14, all worked, so we still support node 14+.

@w666
Copy link
Collaborator Author

w666 commented Jun 18, 2024

I've just published new release 1.0.4 with some improvements.
Planning to include this PR in the next release and increment minor version (1.1.0) as it contains some pretty major changes.

I am still getting feedback about these changes, feel free to add comments. Thanks.

@w666 w666 mentioned this pull request Jun 21, 2024
@w666 w666 merged commit 3c20595 into master Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants