Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated packages #1243

Closed
wants to merge 2 commits into from
Closed

updated packages #1243

wants to merge 2 commits into from

Conversation

vision10
Copy link
Contributor

I have updated most of the outdated packages that are relatively safe and dont break tests to latest

also removed types:
@types/axios - axios provides types
@types/request - no request package

sinon and xml-crypto require code changes

whatwg-mimetype and get-stream require min node version: 18
I think axios-ntlm also requires node v18
get-stream - latest version is now pure ESM. It cannot be require()d from CommonJS

stip-bom
stip-bom@4 requires esModuleInterop flag
stip-bom@5 requires entire package tuned to work with modules
my sugestion: dont use stip-bom package, make function in utilities

@w666
Copy link
Collaborator

w666 commented Jun 14, 2024

I raised a PR with the updated deps, including xml-crypto. But planning to keep it in PR for some time just to get feedback if there is any.

#1242

@w666
Copy link
Collaborator

w666 commented Jun 14, 2024

and I happy to get rid of strip-bom.

@vision10 vision10 closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants