-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse double and floats #985
Conversation
When type is xs:double or xs:float we use parseFloat to convert it to javascript.
@leon I restarted Travis CI and all current tests pass - could you please add tests for your PR? 👍 |
Where do we test all the other serializations? |
Could you also add parsing of xs:long and xs:decimal ? |
I've just come across this issue as didn't realise that type "double" wasn't being converted. Can I help get this PR merged? Given how old this PR is I'm guessing @leon has probably moved on to something else? Do you want me to submit a new PR with some tests? |
Having said that I think it's safer to convert using |
need a test added and conflicts resolved |
When type is xs:double or xs:float we use parseFloat to convert it to javascript.
I'm unsure why this hasn't been done.
Maybe you have a good reason as to why you are not converting floats or doubles.
But since usually people want the data in their native form, I thought I'd suggest this atleast.
Tests:
There were 28 failing tests in master, so I was unable to write any tests.
I'd gladly write tests once master is passing again.