Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy mode setting not working properly #939

Closed
bajzarpa opened this issue Mar 28, 2019 · 3 comments
Closed

Legacy mode setting not working properly #939

bajzarpa opened this issue Mar 28, 2019 · 3 comments
Labels
bug need team repro We acknowledged your report and will soon try to reproduce it

Comments

@bajzarpa
Copy link
Contributor

Version

5.0.5

Browser and OS info

MacOs, Chrome 73

Steps to reproduce

  • Start an application with Vue 2.x and Vuex 1.x
  • Start the Vue Devtools
  • Try to load mutations

What is expected?

Map the mutations properly

What is actually happening?

Throws an error

It looks like the backend/vuex.js cannot read properly the SharedData values.

I've checked and the vuex1 flag is present in the storage with true value, and also looks good on the settings page, but when the backend/vuex.js tries to read it, it's always false.

Screenshots:

https://ibb.co/0DmhLyg
https://ibb.co/CmGJXxv
@Akryum
Copy link
Member

Akryum commented Mar 28, 2019

I'm sorry I can't reproduce this.

@Akryum Akryum added the cannot reproduce We cannot reproduce the problem with the given information. More env information needed. label Mar 28, 2019
@Akryum
Copy link
Member

Akryum commented Apr 5, 2019

@vuejs/vue-devtools Could someone try to reproduce with a Mac?

@bajzarpa
Copy link
Contributor Author

bajzarpa commented Apr 12, 2019 •
edited
Loading

Hi @Akryum,

I've created a sandbox where I was able to reproduce this even on windows and mac.

edit:
The issue is still the same. The flag for the legacy option is present in the local storage, but it's still false in the shared data

@Akryum Akryum added bug need team repro We acknowledged your report and will soon try to reproduce it and removed cannot reproduce We cannot reproduce the problem with the given information. More env information needed. labels Apr 12, 2019
@bajzarpa bajzarpa mentioned this issue Apr 12, 2019
Merged
@Akryum Akryum closed this as completed in fe067b6 Apr 12, 2019
sp1ker pushed a commit to sp1ker/vue-devtools that referenced this issue Aug 24, 2020
@bajzarpa @sp1ker
fix(vuex): Refactor legacy VueX checking, closes vuejs#939 (vuejs#970)
2da0924 
* Change isLegacy checking strategy, adapt mutation handling to vuex 1

* ./src/backend

remove setting and related data

* Check the legacy mode before converting the payload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug need team repro We acknowledged your report and will soon try to reproduce it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bajzarpa @Akryum