#939 Refactor legacy VueX checking #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove setting and related data
bajzarpa
changed the title
sp1ker
pushed a commit
to sp1ker/vue-devtools
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #939
Contains 2 bugfixes.
So as I mentioned in the source issue, the config reading isn't worked for some reason, but instead of applying a separate option, my thought was to better to figure out the current VueX version.
Since the
commitnot exist in the older (as you calllegacy) versions my ide was that to check this function and the existence of it.There was an other compatibility issue as well which caused by how the payload was passed to the mutation handler on legacy mode. I've solved this with simply convert the payload to an array when it's a legacy mode.