fix: using lang attribute with empty string in html template
#5992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangbinwei
force-pushed
the
fix-html-lang
branch
from
145e405
to
7d04553
Compare
|
This would fix my original issue in the way I thought about it, thx @fangbinwei 👍 |
botic
reviewed
Oct 23, 2020
| @@ -1,5 +1,5 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <html lang=""> | |||
There was a problem hiding this comment.
Being an empty attribute should be enough indication for developers to insert the correct language themselves.
haoqunjiang
pushed a commit
that referenced
this pull request
Jan 6, 2021
Fixes #5945 `lang="en"` may be wrong to users, use empty string instead. See : h5bp/html5-boilerplate#1542
This was referenced Mar 16, 2021
Closed
Closed
This was referenced Mar 18, 2021
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5945
lang="en"may be wrong to users, use empty string instead. See : h5bp/html5-boilerplate#1542What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)