Skip to content

Commit

Permalink
Added support for storage retrieval requests in VuFind core code
Browse files Browse the repository at this point in the history
- added support in Voyager/VoyagerRestful drivers (call slips in Voyager land).
- Extended Demo ILS driver to handle holds and storage retrieval requests properly.
- Minor fixes to comments, etc.
  • Loading branch information
EreMaijala authored and demiankatz committed Feb 4, 2014
1 parent a17fbe3 commit 3bec0eb
Show file tree
Hide file tree
Showing 53 changed files with 2,741 additions and 126 deletions.
24 changes: 24 additions & 0 deletions config/vufind/VoyagerRestful.ini
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,30 @@ defaultPickUpLocation = "1"
; link. Use "0" to check all items via ajax. Default is 15.
holdCheckLimit = 15

; This section controls call slip behavior.
[StorageRetrievalRequests]
; Colon-separated list of item types where call slip is allowed
;valid_item_types = 1:2:3

; HMACKeys - A list of form element names that will be analyzed for consistency
; during form processing. Most users should not need to change this setting.
HMACKeys = item_id:holdings_id

; extraFields - A colon-separated list used to display extra visible fields in the
; place call slip request form. Supported values are "comments", "pickUpLocation"
; and "item-issue"
extraFields = item-issue:comments

; The maximum number of holding items to generate request links for. The process of
; checking the API for a valid call slip is intensive. Any items above this this
; limit will have their status checked via ajax or when a user clicks on the
; link. Use "0" to check all items via ajax. Default is 15.
checkLimit = 0

; Optional help texts that can be displayed on the call slip form
;helpText = "Help text for all languages."
;helpText[en-gb] = "Help text for English language."

; This section controls renewal behavior.
[Renewals]
; If this is set to true, we will only display "renewal" checkboxes if items are able
Expand Down
5 changes: 5 additions & 0 deletions config/vufind/config.ini
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@ allow_holds_override = false
; default is false
cancel_holds_enabled = false

; Determines if storage retrieval requests can be cancelled or not.
; Options are true or false.
; default is false
cancel_storage_retrieval_requests_enabled = false

; Determines if item can be renewed or not. Options are true or false.
; default is false
renewals_enabled = false
Expand Down
15 changes: 14 additions & 1 deletion languages/ca.ini
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,19 @@ Start Page = "Pàgina d’inici"
starting from = "començant des de"
Status = Estat
status_unknown_message = "Comprovació en temps real no disponible"
storage_retrieval_request_available = "Disponible per recollir"
storage_retrieval_request_cancel_fail = "La petició no es pot cancel·lar. Si us plau, contacteu amb el taulell de préstec."
storage_retrieval_request_cancel_success = "La vostra petició s’ha cancel·lat correctament"
storage_retrieval_request_cancel_success_items = "petició(ns) s’han cancel·lat correctament"
storage_retrieval_request_comments = Comentaris
storage_retrieval_request_date_invalid = "Introduïu una data vàlida"
storage_retrieval_request_date_past = "Introduïu una data futura"
storage_retrieval_request_error_fail = "Ha fallat la vostra petició. Contacteu amb el taulell de préstec per sol·licitar ajuda"
storage_retrieval_request_invalid_pickup = "Heu introduït una localització de recollida no vàlida. Torneu-ho a intentar"
storage_retrieval_request_place_fail_missing = "Ha fallat la vostra petició. Algunes dades s’han perdut. Contacteu amb el taulell de circulació per sol·licitar ajuda."
storage_retrieval_request_place_success = "Petició correcta"
storage_retrieval_request_submit_text = "Solicitar lloc"
storage_retrieval_request_volume = Volum
Subcollection = "Subcol·lecció"
Subject = Matèria
Subject Area = "Àrea temàtica"
Expand Down Expand Up @@ -774,4 +787,4 @@ Your Profile = "Perfil"
Your search terms = "Termes de cerca"
Your Tags = "Etiquetes"
Zip = Zip
zoom = "Ampliar"
zoom = "Ampliar"
15 changes: 14 additions & 1 deletion languages/cs.ini
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,19 @@ Start Page = "Začít na straně"
starting from = "začínající"
Status = Stav
status_unknown_message = "Live Status nedostupný"
storage_retrieval_request_available = "Připraveno k vyzvednutí"
storage_retrieval_request_cancel_fail = "Váš požadavek nebyl smazán. Kontaktujte obsluhu pro další informace."
storage_retrieval_request_cancel_success = "Váš požadavek byl úspěšně smazán."
storage_retrieval_request_cancel_success_items = "požadavků bylo smazáno"
storage_retrieval_request_comments = Komentáře
storage_retrieval_request_date_invalid = "Zadejte platné datum"
storage_retrieval_request_date_past = "Zadejte datum v budoucnosti"
storage_retrieval_request_error_fail = "Váš požadavek selhal. Kontaktujte obsluhu pro další informace."
storage_retrieval_request_invalid_pickup = "Neplatné místo vyzvednutí. Zkuste to znova."
storage_retrieval_request_place_fail_missing = "Váš požadavek selhal. Chybí některé údaje. Kontaktujte obsluhu pro další informace."
storage_retrieval_request_place_success = "Váš požadavek byl úspěšně vložen."
storage_retrieval_request_submit_text = "Zadat požadavek"
storage_retrieval_request_volume = Část
Subcollection = "Část sbírky"
Subject = Téma
Subject Area = "Předmětová oblast"
Expand Down Expand Up @@ -806,4 +819,4 @@ Your Profile = "Váš profil"
Your search terms = "Vyhledávané termíny"
Your Tags = "Vaše tagy"
Zip = PSČ
zoom = "Přiblížit"
zoom = "Přiblížit"
15 changes: 14 additions & 1 deletion languages/cy.ini
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,19 @@ Start Page ="Tudalen Gychwyn"
starting from = "yn dechrau o"
Status = Statws
status_unknown_message = "Nid yw'r Statws Byw ar Gael"
storage_retrieval_request_available = "Ar gael i Gasglu"
storage_retrieval_request_cancel_fail = "Ni chanslwyd eich cais. Cysylltwch â'r ddesg fenthyca am gymorth pellach"
storage_retrieval_request_cancel_success = "Canslwyd eich cais yn llwyddiannus"
storage_retrieval_request_cancel_success_items = "Canslwyd y cais/ceisiadau yn llwyddiannus"
storage_retrieval_request_comments = Sylwadau
storage_retrieval_request_date_invalid = "Rhowch ddyddiad dilys os gwelwch yn dda"
storage_retrieval_request_date_past = "Rhowch ddyddiad yn y dyfodol os gwelwch yn dda"
storage_retrieval_request_error_fail = "Mae eich cais wedi methu. Cysylltwch â'r ddesg fenthyca am gymorth pellach"
storage_retrieval_request_invalid_pickup = "Rhoddwyd lleoliad casglu annilys. Rhowch gynnig eto"
storage_retrieval_request_place_fail_missing = "Mae eich cais wedi methu. Roedd peth data ar goll. Cysylltwch â'r ddesg fenthyca am gymorth pellach "
storage_retrieval_request_place_success = "Roedd eich cais yn llwyddiannus"
storage_retrieval_request_submit_text = "Gosod Cais"
storage_retrieval_request_volume = Sain
Subcollection = "Is-gasgliad"
Subject = Pwnc
Subject Area ="Maes Pwnc"
Expand Down Expand Up @@ -809,4 +822,4 @@ Your Profile ="Proffil"
Your search terms ="Fy Eitemau Chwilio"
Your Tags ="Tagiau"
Zip = Zip
zoom = "Chwyddo"
zoom = "Chwyddo"
16 changes: 14 additions & 2 deletions languages/da.ini
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,19 @@ Start a new Basic Search = "Start en ny almindelig søgning"
Start Page = "Startside"
starting from = "startende fra"
Status = Status
storage_retrieval_request_available = "Kan afhentes"
storage_retrieval_request_cancel_fail = "Din forespørgsel blev aflyst. Kontakt venligst udlånsskranken for yderligere assistance"
storage_retrieval_request_cancel_success = "Din forespørgsel blev aflyst"
storage_retrieval_request_cancel_success_items = "Dine forespørgsler blev aflyst"
storage_retrieval_request_comments = Kommentar
storage_retrieval_request_date_invalid = "Vær venlig at tilføje en gyldig dato"
storage_retrieval_request_date_past = "Vær venlig at tilføje en fremtidig dato "
storage_retrieval_request_error_fail = "Din forespørgsel kunne ikke gennemføres. Kontakt venligst udlånsskranken for yderligere assistance"
storage_retrieval_request_invalid_pickup = "Afhentningslokation ugyldig. Prøv venligst igen"
storage_retrieval_request_place_fail_missing = "Din forespørgsel kunne ikke gennemføres pga. en fejl. Kontakt venligst udlånsskranken for yderligere assistance”
storage_retrieval_request_place_success = "Din forespørgsel blev godkendt"
storage_retrieval_request_submit_text = "Lav forespørgsel"
storage_retrieval_request_volume = Bind
Subject = Fag
Subject Area = "Fagområde"
Subject Recommendations = "Faganbefalinger"
Expand Down Expand Up @@ -648,5 +661,4 @@ Your Lists = "Dine lister"
Your Profile = "Din profil"
Your search terms = "Dine søgeord"
Your Tags = "Dine Tags"
Zip = Zip ø

Zip = "Zip ø"
13 changes: 13 additions & 0 deletions languages/de.ini
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,19 @@ Start Page = "Erste Seite"
starting from = "ab"
Status = Status
status_unknown_message = "Live-Status nicht verfügbar"
storage_retrieval_request_available = "Abholbereit"
storage_retrieval_request_cancel_fail = "Ihre Bestellung konnte nicht annulliert werden. Bitte kontaktieren Sie ihre Bibliothek für weitere Hilfe"
storage_retrieval_request_cancel_success = "Ihre Bestellung wurde erfolgreich annulliert"
storage_retrieval_request_cancel_success_items = "Bestellung(en) wurden erfolgreich annulliert"
storage_retrieval_request_comments = Kommentare
storage_retrieval_request_date_invalid = "Bitte geben Sie ein gültiges Datum ein"
storage_retrieval_request_date_past = "Bitte geben Sie ein Datum in der Zukunft an"
storage_retrieval_request_error_fail = "Ihre Bestellung ist fehlgeschlagen. Bitte kontaktieren Sie ihre Bibliothek für weitere Hilfe"
storage_retrieval_request_invalid_pickup = "Es wurde ein ungültiger Abholort eingegeben. Bitte versuchen Sie es erneut"
storage_retrieval_request_place_fail_missing = "Ihre Bestellung ist fehlgeschlagen. Es fehlen Angaben. Bitte kontaktieren Sie ihre Bibliothek für weitere Hilfe"
storage_retrieval_request_place_success = "Ihre Bestellung war erfolgreich"
storage_retrieval_request_submit_text = "Bestellen"
storage_retrieval_request_volume = Jahrgang
Subcollection = "Teilsammlung"
Subject = Schlagwort
Subject Area = Schlagwortumfeld
Expand Down
13 changes: 13 additions & 0 deletions languages/el.ini
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,19 @@ Start Page = "Αρχική"
starting from = "αρχίζοντας με τον όρο"
Status = Κατάσταση
status_unknown_message = "Η τρέχουσα κατάσταση είναι άγνωστη"
storage_retrieval_request_available = "Διαθέσιμο"
storage_retrieval_request_cancel_fail = "Το αίτημά σας δεν ακυρώθηκε. Απευθυνθείτε στην εξυπηρέτηση για βοήθεια"
storage_retrieval_request_cancel_success = "Το αίτημά σας ακυρώθηκε με επιτυχία"
storage_retrieval_request_cancel_success_items = "Τα αιτήματά σας ακυρώθηκαν με επιτυχία"
storage_retrieval_request_comments = Σχόλια
storage_retrieval_request_date_invalid = "Παρακαλώ εισάγετε έγκυρη ημερομηνία"
storage_retrieval_request_date_past = "Παρακαλώ εισάγετε μελλοντική ημερομηνία"
storage_retrieval_request_error_fail = "Το αίτημά σας απέτυχε. Απευθυνθείτε στην εξυπηρέτηση για βοήθεια"
storage_retrieval_request_invalid_pickup = "Η βιβλιοθήκη παραλαβής δεν είναι έγκυρη. Παρακαλώ εισάγετε άλλη"
storage_retrieval_request_place_fail_missing = "Το αίτημά σας απέτυχε. Ελλιπή στοιχεία. Απευθυνθείτε στην εξυπηρέτηση για βοήθεια"
storage_retrieval_request_place_success = "Το αίτημά σας καταχωρήθηκε"
storage_retrieval_request_submit_text = "Αίτημα κράτησης"
storage_retrieval_request_volume = Τόμος
Subcollection = "Υποομάδα Συλλογής"
Subject = Θέμα
Subject Area = "Περιοχή θεμάτων"
Expand Down
7 changes: 6 additions & 1 deletion languages/en-gb.ini
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ Multiple Call Numbers = "Multiple Classmarks"
My Favorites = "My Favourites"
pick_up_location = "Collection Library"
sort_callnumber = "Classmark"
storage_retrieval_request_available = "Available for Collection"
storage_retrieval_request_cancel_fail = "Your request was not canceled. Please contact the issue desk for further assistance"
storage_retrieval_request_error_fail = "Your request failed. Please contact the issue desk for further assistance"
storage_retrieval_request_place_fail_missing = "Your request failed. Some data was missing. Please contact the issue desk for further assistance"
storage_retrieval_request_profile_html = "For storage retrieval request information, please establish your <a href="%%url%%">Library Catalogue Profile</a>."
too_many_favorites = "This list is too large to display all at once. Try rearranging your favourites into more lists or limiting using tags."
You do not have any saved resources = "You do not have any saved resources. Perform a search and use the Add to Favourites button to save items."
Your Favorites = "Your Favourites"
Your Favorites = "Your Favourites"
31 changes: 31 additions & 0 deletions languages/en.ini
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ confirm_dialog_no = Cancel
confirm_dialog_yes = Confirm
confirm_hold_cancel_all_text = "Do you wish to cancel all your current holds?"
confirm_hold_cancel_selected_text = "Do you wish to cancel your selected holds?"
confirm_storage_retrieval_request_cancel_all_text = "Do you wish to cancel all your current storage retrieval requests?"
confirm_storage_retrieval_request_cancel_selected_text = "Do you wish to cancel your selected storage retrieval requests?"
Contents = Contents
Contributors = "Contributors"
Copies = Copies
Expand Down Expand Up @@ -693,6 +695,34 @@ Start Page = "Start Page"
starting from = "starting from"
Status = Status
status_unknown_message = "Live Status Unavailable"
storage_retrieval_request_available = "Available for Pickup"
storage_retrieval_request_canceled = "Canceled"
storage_retrieval_request_cancel = "Cancel Storage Retrieval Request"
storage_retrieval_request_cancel_all = "Cancel All Storage Retrieval Requests"
storage_retrieval_request_cancel_fail = "Your request was not canceled. Please contact the circulation desk for further assistance"
storage_retrieval_request_cancel_selected = "Cancel Selected Storage Retrieval Requests"
storage_retrieval_request_cancel_success = "Your request was successfully canceled"
storage_retrieval_request_cancel_success_items = "request(s) were successfully canceled"
storage_retrieval_request_check_text = "Check Storage Retrieval Request"
storage_retrieval_request_comments = "Comments"
storage_retrieval_request_date_invalid = "Please enter a valid date"
storage_retrieval_request_date_past = "Please enter a date in the future"
storage_retrieval_request_empty_selection = "No storage retrieval requests were selected"
storage_retrieval_request_error_blocked = "You do not have sufficient privileges to place a storage retrieval request on this item"
storage_retrieval_request_error_fail = "Your request failed. Please contact the circulation desk for further assistance"
storage_retrieval_request_invalid_pickup = "An invalid pick up location was entered. Please try again"
storage_retrieval_request_issue = "Date"
storage_retrieval_request_place_fail_missing = "Your request failed. Some data was missing. Please contact the circulation desk for further assistance"
storage_retrieval_request_place_success = "Your request was successful"
storage_retrieval_request_place_text = "Place a Storage Retrieval Request"
storage_retrieval_request_processed = "Processed"
storage_retrieval_request_profile_html = "For storage retrieval request information, please establish your <a href="%%url%%">Library Catalog Profile</a>."
storage_retrieval_request_reference = "Reference"
storage_retrieval_request_selected_item = "Selected item"
storage_retrieval_request_submit_text = "Place Request"
storage_retrieval_request_volume = "Volume"
storage_retrieval_request_year = "Year"
Storage Retrieval Requests = "Storage Retrieval Requests"
Subcollection = Subcollection
Subject = Subject
Subject Area = "Subject Area"
Expand Down Expand Up @@ -797,6 +827,7 @@ You do not have any fines = "You do not have any fines"
You do not have any holds or recalls placed = "You do not have any holds or recalls placed"
You do not have any items checked out = "You do not have any items checked out"
You do not have any saved resources = "You do not have any saved resources. Perform a search and use the Add to Favorites button to save items."
You do not have any storage retrieval requests placed = "You do not have any storage retrieval requests placed"
You must be logged in first = "You must be logged in first"
Your Account = "Your Account"
Your book bag is empty = "Your book bag is empty"
Expand Down
15 changes: 14 additions & 1 deletion languages/es.ini
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,19 @@ Start Page = "Página de inicio"
starting from = "iniciando desde"
Status = Estado
status_unknown_message = "Estatus de actividad no disponible"
storage_retrieval_request_available = "Disponible para llevar"
storage_retrieval_request_cancel_fail = "Su solicitud no ha sido cancelada, por favor contactar con el mostrador de circulación para más ayuda"
storage_retrieval_request_cancel_success = "Su solicitud ha sido cancelada"
storage_retrieval_request_cancel_success_items = "Su solicitud fue cancelada"
storage_retrieval_request_comments = Comentarios
storage_retrieval_request_date_invalid = "Introduzca una fecha valida"
storage_retrieval_request_date_past = "Introduzca una fecha futura"
storage_retrieval_request_error_fail = "Su solicitud ha fallado. Contacte con el personal del mostrador para ayuda"
storage_retrieval_request_invalid_pickup = "Ubicación inválida, intente de nuevo."
storage_retrieval_request_place_fail_missing = "Su solicitud ha fallado, contactar al personal del mostrador de circulación"
storage_retrieval_request_place_success = "Se ha realizado su solicitud"
storage_retrieval_request_submit_text = "Hacer solicitud"
storage_retrieval_request_volume = Volumen
Subcollection = "Subcolección"
Subject = Materia
Subject Area = "Areas Temáticas"
Expand Down Expand Up @@ -807,4 +820,4 @@ Your Profile = "Su Perfil"
Your search terms = "Sus términos de búsqueda"
Your Tags = "Sus Etiquetas"
Zip = Código Postal
zoom = "Enfocar"
zoom = "Enfocar"
13 changes: 13 additions & 0 deletions languages/eu.ini
Original file line number Diff line number Diff line change
Expand Up @@ -1311,6 +1311,19 @@ Start Page = "Etxeko orrialdea"
starting from = "-tik hasten"
Status = Egoera
status_unknown_message = "Egoera zuzenean ez dago erabilgarri"
storage_retrieval_request_available = "Eramateko eskuragarri"
storage_retrieval_request_cancel_fail = "Zure eskaera ezeztatua izan da. Mesedez, mostradoretik pasa."
storage_retrieval_request_cancel_success = "Zure eskaera ezeztatua izan da"
storage_retrieval_request_cancel_success_items = "Zure eskaera ezeztatua izan da"
storage_retrieval_request_comments = "Iruzkinak"
storage_retrieval_request_date_invalid = "baliodun data sartu"
storage_retrieval_request_date_past = "data sartu"
storage_retrieval_request_error_fail = "Zure eskaeran errorea egon da. Mesedez mostradoretik pasa lagundu zaitzaten"
storage_retrieval_request_invalid_pickup = "Kokapena ez da baliagarria. Berriz saiatu."
storage_retrieval_request_place_fail_missing = "Zure eskaeran errorea gertatu da. Mostradoretik pasa lagundu zaitzaten."
storage_retrieval_request_place_success = "Zure eskaera burutu da"
storage_retrieval_request_submit_text = "Eskaera egin"
storage_retrieval_request_volume = Bolumena
Subcollection = "Azpibilduma"
Subject = Gaia
Subject Area = Jakintza adarra
Expand Down
Loading

12 comments on commit 3bec0eb

@hackartisan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this has already been committed but in general and moving forward I think we should avoid changing the names of public functions! When there's a strong argument to do so, maybe we could discuss / notify via the mailing list.

@demiankatz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do make note of things like this in the changelog of the wiki -- see https://vufind.org/wiki/changelog. In this particular case, I made the judgment call that the new name made more sense and the use of the function was fairly isolated... but perhaps it would have been better to be more cautious. There's also the possibility of adding a method with the old name that throws a deprecation warning as a wrapper. That just felt like overkill to me in this instance.

@hackartisan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there it is in the changelog! It's hard because different people are looking in different places. I don't have a habit of checking that page regularly, so for me an announcement on the mailing list would have saved a bit of oh-no-i-have-lost-code-somehow panic.

@hackartisan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, I agree the function is not widely used but I wouldn't be surprised if that is one of the more frequently edited templates.

@demiankatz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is true. I guess the way I've been looking at this is this:

1.) If you're working from master and have custom templates, you should have a procedure where whenever you do a merge, you look at all the templates that have changed and update your local custom versions to match. Otherwise, you'll run into problems down the road (breaks like this one, or at least missing functionality).

2.) If you're working from official releases, you should look at the change log whenever you upgrade and it will warn you of major issues to worry about. A large-scale diff a la #1 is still probably a good idea.

Not saying that entirely justifies making major changes without guilt -- but that's how I rationalized this one. And point #1 is really important. This is the one thing that troubles me about VuFind's convenient separation of local changes -- you really have to be vigilant about certain types of core changes or else you can run into problems. It would be really nice if there were some sort of magic version control mechanism that could say "file y is derived from file x; file x just changed -- you'd better do a merge" but as far as I know, that's a little too advanced for existing systems.

Anyway, I'm always open to suggestions for improvement!

@hackartisan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is perfectly fair for me to bring up what is practically a law of software development (don't change the signature of a public method).

@hackartisan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion for improvement is as follows: try to post backwards-incompatible changes more widely. Maybe mention them on dev call minutes and post them to the dev list. Thanks for your consideration.

@demiankatz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you're absolutely right -- sorry if I seemed to be dismissing that point. You just got me off on a tangent thinking about the general challenges of maintaining local themes (even in the absence of gotchas like this particular one). I've been feeling for a while like we need a tool to help with this, but I'm not sure that one exists.

In any case, you've persuaded me that it's worth the very low overhead of adding a getHoldUrl() wrapper method around getRequestUrl() to maintain backward compatibility and prevent confusion. Just pushed that up.

I also appreciate the feedback -- I'm finding it increasingly difficult to review new code as thoughtfully and thoroughly as I used to (and would like to) because the volume keeps increasing, but I also feel pressure to keep things flowing since there's nothing worse than a stale pull request! Any time others have to put eyes on things is extremely valuable.

@demiankatz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, in addition to that, I'll make a greater effort to be more consistent about reporting future potential-backward-breakers in more venues. I'll try to remember to make a policy that, if it's important enough to add to the changelog, it's important enough to announce elsewhere.

@hackartisan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. Your maintenance of this project never fails to impress. I actually would like to try to keep a closer eye on PRs and code changes. I will mess with my notification settings.

@EreMaijala
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take part of the blame here. I actually had adding a compatibility wrapper in my mind at some point, but somehow forgot to bring that up. I apologize for the the trouble.

@demiankatz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem -- it's good to see that things like this get caught before we go to release! (Thanks again, Anna!).

Please sign in to comment.