Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update de.ini #1

Merged
merged 1 commit into from
Aug 1, 2013
Merged

Update de.ini #1

merged 1 commit into from
Aug 1, 2013

Conversation

hauschke
Copy link
Contributor

@hauschke hauschke commented Aug 1, 2013

typo

demiankatz added a commit that referenced this pull request Aug 1, 2013
@demiankatz
Merge pull request #1 from hauschke/patch-1
5716af8 
Update de.ini
@demiankatz demiankatz merged commit 5716af8 into vufind-org:master Aug 1, 2013
@hauschke hauschke deleted the patch-1 branch August 15, 2013 13:41
atz pushed a commit to atz/vufind that referenced this pull request Dec 17, 2013
@demiankatz
Merge pull request vufind-org#1 from atz/mmilton_master
134d309 
Whitespace cleanup (dos2unix, s/ $//g)
@demiankatz demiankatz mentioned this pull request Jan 28, 2014
Closed
demiankatz referenced this pull request Mar 7, 2014
@EreMaijala @demiankatz
Added support for storage retrieval requests in VuFind core code
3bec0eb 
- added support in Voyager/VoyagerRestful drivers (call slips in Voyager land).
- Extended Demo ILS driver to handle holds and storage retrieval requests properly.
- Minor fixes to comments, etc.
@DCL-jbannon DCL-jbannon mentioned this pull request Apr 4, 2014
Closed
tillk pushed a commit to gbv/vufind that referenced this pull request Apr 29, 2015
@dlacy
Merge pull request vufind-org#1 from bbusenius/OLE
14230bd 
Database API override of getMyTransactions, added a configurable default
EreMaijala pushed a commit to EreMaijala/vufind that referenced this pull request Jun 17, 2015
Merge pull request vufind-org#1 from NatLibFi/master
f033fbc 
Syncing my fork
demiankatz pushed a commit that referenced this pull request Aug 7, 2015
@blackmolly
Merge pull request #1 from vufind-org/ebsco-fixes
0fb0a61 
Ebsco fixes
@jochen-lienhard jochen-lienhard mentioned this pull request Feb 17, 2016
Closed
@lmgonzales lmgonzales mentioned this pull request Jun 28, 2016
Closed
demiankatz pushed a commit that referenced this pull request Jul 5, 2016
@lmgonzales @demiankatz
Update for compatibility with MySQL 5.7+ and PostgreSQL
ec63614 
getUniqueResources, getUniqueTags, and getUniqueUsers was failing due to mySQL5.7 compatibility issues. The error being thrown by mySQL was: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by

To fix, we have to either turn off the only_full_group_by option or specifically select the columns that are used instead of selecting *.

See: https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html for more info.

PostgreSQL was failing due to fields being present in ORDER but missing from GROUP BY. This has also been corrected.
Piligrim2911 added a commit to malekula/vufind4LIBFL that referenced this pull request Oct 12, 2017
@Piligrim2911
Восстановление после переключения на ветку develop vufind-org#1-2
b4b3e5d
@kellyflo kellyflo mentioned this pull request Mar 24, 2020
Merged
Witiko added a commit to Witiko/vufind that referenced this pull request Mar 12, 2021
@Witiko
Make the background of active navigation tabs white
c889551 
Closes vufind-org#1.
@LuomaJuha LuomaJuha mentioned this pull request Apr 11, 2023
Merged
@sturkel89 sturkel89 mentioned this pull request Dec 18, 2023
Merged
3 tasks
@demiankatz demiankatz mentioned this pull request Feb 29, 2024
Closed
3 tasks
dltj added a commit to dltj/vufind that referenced this pull request Oct 7, 2024
@dltj
Handle empty cat_password columns in user row
339e19e 
This corrects a problem with new VuFind users being created from a Shibboleth login. Without this change, we see this exception and stack trace:

```
2024-10-07T14:04:23-04:00 ERR (3): VuFind\Auth\Manager: Laminas\Db\RowGateway\Exception\InvalidArgumentException: Not a valid column in this row: cat_password in /usr/local/vufind-pmalibrary/vendor/laminas/laminas-db/src/RowGateway/AbstractRowGateway.php:294
Stack trace:
#0 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Db/Row/User.php(964): Laminas\Db\RowGateway\AbstractRowGateway->__get()
vufind-org#1 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Auth/ILSAuthenticator.php(224): VuFind\Db\Row\User->getRawCatPassword()
vufind-org#2 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Auth/Shibboleth.php(240): VuFind\Auth\ILSAuthenticator->getCatPasswordForUser()
vufind-org#3 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Auth/Manager.php(743): VuFind\Auth\Shibboleth->authenticate()
vufind-org#4 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Controller/MyResearchController.php(217): VuFind\Auth\Manager->login()
vufind-org#5 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-mvc/src/Controller/AbstractActionController.php(72): VuFind\Controller\MyResearchController->homeAction()
vufind-org#6 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Controller/Feature/CatchIlsExceptionsTrait.php(76): Laminas\Mvc\Controller\AbstractActionController->onDispatch()
vufind-org#7 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-eventmanager/src/EventManager.php(319): VuFind\Controller\MyResearchController->onDispatch()
vufind-org#8 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-eventmanager/src/EventManager.php(177): Laminas\EventManager\EventManager->triggerListeners()
vufind-org#9 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-mvc/src/Controller/AbstractController.php(105): Laminas\EventManager\EventManager->triggerEventUntil()
vufind-org#10 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-mvc/src/DispatchListener.php(117): Laminas\Mvc\Controller\AbstractController->dispatch()
vufind-org#11 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-eventmanager/src/EventManager.php(319): Laminas\Mvc\DispatchListener->onDispatch()
vufind-org#12 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-eventmanager/src/EventManager.php(177): Laminas\EventManager\EventManager->triggerListeners()
vufind-org#13 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-mvc/src/Application.php(319): Laminas\EventManager\EventManager->triggerEventUntil()
vufind-org#14 /usr/local/vufind-pmalibrary/public/index.php(71): Laminas\Mvc\Application->run()
```
demiankatz pushed a commit to dltj/vufind that referenced this pull request Oct 8, 2024
@dltj @demiankatz
Handle empty cat_password columns in user row
b7f36aa 
This corrects a problem with new VuFind users being created from a Shibboleth login. Without this change, we see this exception and stack trace:

```
2024-10-07T14:04:23-04:00 ERR (3): VuFind\Auth\Manager: Laminas\Db\RowGateway\Exception\InvalidArgumentException: Not a valid column in this row: cat_password in /usr/local/vufind-pmalibrary/vendor/laminas/laminas-db/src/RowGateway/AbstractRowGateway.php:294
Stack trace:
#0 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Db/Row/User.php(964): Laminas\Db\RowGateway\AbstractRowGateway->__get()
vufind-org#1 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Auth/ILSAuthenticator.php(224): VuFind\Db\Row\User->getRawCatPassword()
vufind-org#2 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Auth/Shibboleth.php(240): VuFind\Auth\ILSAuthenticator->getCatPasswordForUser()
vufind-org#3 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Auth/Manager.php(743): VuFind\Auth\Shibboleth->authenticate()
vufind-org#4 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Controller/MyResearchController.php(217): VuFind\Auth\Manager->login()
vufind-org#5 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-mvc/src/Controller/AbstractActionController.php(72): VuFind\Controller\MyResearchController->homeAction()
vufind-org#6 /usr/local/vufind-pmalibrary/module/VuFind/src/VuFind/Controller/Feature/CatchIlsExceptionsTrait.php(76): Laminas\Mvc\Controller\AbstractActionController->onDispatch()
vufind-org#7 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-eventmanager/src/EventManager.php(319): VuFind\Controller\MyResearchController->onDispatch()
vufind-org#8 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-eventmanager/src/EventManager.php(177): Laminas\EventManager\EventManager->triggerListeners()
vufind-org#9 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-mvc/src/Controller/AbstractController.php(105): Laminas\EventManager\EventManager->triggerEventUntil()
vufind-org#10 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-mvc/src/DispatchListener.php(117): Laminas\Mvc\Controller\AbstractController->dispatch()
vufind-org#11 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-eventmanager/src/EventManager.php(319): Laminas\Mvc\DispatchListener->onDispatch()
vufind-org#12 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-eventmanager/src/EventManager.php(177): Laminas\EventManager\EventManager->triggerListeners()
vufind-org#13 /usr/local/vufind-pmalibrary/vendor/laminas/laminas-mvc/src/Application.php(319): Laminas\EventManager\EventManager->triggerEventUntil()
vufind-org#14 /usr/local/vufind-pmalibrary/public/index.php(71): Laminas\Mvc\Application->run()
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauschke @demiankatz