Update for compatibility with MySQL 5.7+ #744
Conversation
getUniqueResources, getUniqueTags, and getUniqueUsers was failing due to mySQL5.7 compatibility issues. The error being thrown by mySQL was: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by To fix, we have to either turn off the only_full_group_by option or specifically select the columns that are used instead of selecting *. See: https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html for more info.
|
Thanks for this! I've committed it with some changes as ec63614 -- as it turns out, the initial solution from this PR doesn't work with PostgreSQL because the ANY_VALUE function is MySQL-specific. I replaced ANY_VALUE with MAX, which should have the same effect while being a bit more universally compatible (at the price of, probably, slightly worse performance). Additionally, there were some order-related problems that were breaking this functionality in PostgreSQL, so I went ahead and fixed those at the same time. Thanks again for improving VuFind's database compatibility! Hopefully this will reduce problems for many users going forward. |
|
Thanks for updating the PR so that it works with PostgreSQL, and getting it merged into master. I appreciate the help with the code! |
getUniqueResources, getUniqueTags, and getUniqueUsers was failing due to mySQL5.7 compatibility issues. The error being thrown by mySQL was: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
To fix, we have to specifically select the columns that are used instead of selecting *.
See: https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html for more info.