Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6629: call check_kmod within a standard config function #3932

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Aug 2, 2024

Change Summary

As with #3927, move the remaining calls to check_kmod within a standard function, with placement determined by the needs of the config script.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Move the remaining calls to check_kmod within a standard function,
with placement determined by the needs of the config script.
@jestabro jestabro self-assigned this Aug 2, 2024
@jestabro jestabro requested a review from a team as a code owner August 2, 2024 14:05
Copy link

github-actions bot commented Aug 2, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Aug 2, 2024


warning: Unused Warning imported from vyos.base in src/conf_mode/vpn_ipsec.py:28.

@dmbaturin dmbaturin merged commit b5e3612 into vyos:current Aug 2, 2024
12 of 13 checks passed
@jestabro
Copy link
Contributor Author

jestabro commented Aug 2, 2024

@Mergifyio backport circinus

Copy link
Contributor

mergify bot commented Aug 2, 2024

backport circinus

✅ Backports have been created

dmbaturin added a commit that referenced this pull request Aug 3, 2024
T6629: call check_kmod within a standard config function (backport #3932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants