Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6629: call check_kmod within a standard config function (backport #3932) #3935

Merged
merged 1 commit into from
Aug 3, 2024
Merged

T6629: call check_kmod within a standard config function (backport #3932) #3935

merged 1 commit into from
Aug 3, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 2, 2024

Change Summary

As with #3927, move the remaining calls to check_kmod within a standard function, with placement determined by the needs of the config script.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
This is an automatic backport of pull request #3932 done by [Mergify](https://mergify.com).

@jestabro @mergify
T6629: call check_kmod within a standard config function
7c93698 
Move the remaining calls to check_kmod within a standard function,
with placement determined by the needs of the config script.

(cherry picked from commit 95eef73)
@mergify mergify bot requested a review from a team as a code owner August 2, 2024 16:12
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, c-po and nicolas-fort and removed request for a team August 2, 2024 16:12
@mergify mergify bot mentioned this pull request Aug 2, 2024
Merged
12 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

👍
No issues in PR Title / Commit Title

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

👍
No issues in unused-imports

@dmbaturin dmbaturin merged commit f5b4f5e into circinus Aug 3, 2024
8 checks passed
@mergify mergify bot deleted the mergify/bp/circinus/pr-3932 branch August 3, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@fett0 fett0 fett0 approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@c-po c-po Awaiting requested review from c-po c-po is a code owner automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort is a code owner automatically assigned from vyos/reviewers

Assignees
No one assigned
Labels
circinus
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmbaturin @fett0 @jestabro