Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysctl: T3204: restore sysctl settings overwritten by tuned #3945

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Aug 5, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

  • system options
  • system sysctl

Proposed changes

Add dependency on sysctl settings for system options

How to test

Smoketest result

$ /usr/libexec/vyos/tests/smoke/cli/test_system_option.py
test_ctrl_alt_delete (__main__.TestSystemOption.test_ctrl_alt_delete) ... ok
test_performance (__main__.TestSystemOption.test_performance) ... ok
test_reboot_on_panic (__main__.TestSystemOption.test_reboot_on_panic) ... ok

----------------------------------------------------------------------
Ran 3 tests in 13.557s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po requested a review from a team as a code owner August 5, 2024 15:11
Copy link

github-actions bot commented Aug 5, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Aug 5, 2024

👍
No issues in unused-imports

@c-po c-po enabled auto-merge August 5, 2024 15:15
@dmbaturin dmbaturin changed the title sysctl: T3204: restore sysctl setttings overwritten by tuned sysctl: T3204: restore sysctl settings overwritten by tuned Aug 5, 2024
@c-po c-po merged commit 254ea4c into vyos:current Aug 6, 2024
13 of 14 checks passed
@c-po c-po deleted the T3204-sysctl branch August 11, 2024 12:55
@c-po
Copy link
Member Author

c-po commented Aug 23, 2024

@Mergifyio backport sagitta circinus

Copy link

mergify bot commented Aug 23, 2024

backport sagitta circinus

✅ Backports have been created

dmbaturin added a commit that referenced this pull request Aug 23, 2024
sysctl: T3204: restore sysctl settings overwritten by tuned (backport #3945)
c-po added a commit that referenced this pull request Aug 24, 2024
sysctl: T3204: restore sysctl settings overwritten by tuned (backport #3945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants