Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysctl: T3204: restore sysctl settings overwritten by tuned (backport #3945) #4010

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 23, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

  • system options
  • system sysctl

Proposed changes

Add dependency on sysctl settings for system options

How to test

Smoketest result

$ /usr/libexec/vyos/tests/smoke/cli/test_system_option.py
test_ctrl_alt_delete (__main__.TestSystemOption.test_ctrl_alt_delete) ... ok
test_performance (__main__.TestSystemOption.test_performance) ... ok
test_reboot_on_panic (__main__.TestSystemOption.test_reboot_on_panic) ... ok

----------------------------------------------------------------------
Ran 3 tests in 13.557s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3945 done by [Mergify](https://mergify.com).

@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Aug 23, 2024
Copy link

github-actions bot commented Aug 23, 2024

👍
No issues in PR Title / Commit Title

@c-po c-po force-pushed the mergify/bp/sagitta/pr-3945 branch from 578738f to b393899 Compare August 23, 2024 06:06
@c-po c-po self-assigned this Aug 23, 2024
@c-po c-po removed the conflicts label Aug 23, 2024
@vyos vyos deleted a comment from mergify bot Aug 23, 2024
@dmbaturin dmbaturin merged commit 94908b7 into sagitta Aug 23, 2024
8 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3945 branch August 23, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

3 participants