-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6701: Added ability to disable the container DNS plugin #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlogic
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
fett0
September 5, 2024 19:23
👍 |
✅ No issues found in unused-imports check.. Please refer the workflow run |
dvlogic
changed the title
Added ability to disables the container DNS plugin T6701
T6701: Added ability to disables the container DNS plugin
Sep 5, 2024
Change please commit message |
dvlogic
force-pushed
the
Allow_Container_DNS_Disable
branch
3 times, most recently
from
September 5, 2024 21:43
bc4c9c9
to
0306adf
Compare
c-po
requested changes
Sep 6, 2024
dmbaturin
changed the title
T6701: Added ability to disables the container DNS plugin
T6701: Added ability to disable the container DNS plugin
Sep 10, 2024
Updated the commit to add the changes requested by Christian Breunig |
c-po
force-pushed
the
Allow_Container_DNS_Disable
branch
from
September 11, 2024 05:42
e2b9574
to
bd12528
Compare
|
c-po
approved these changes
Sep 11, 2024
Add ability to set the container network with a disable-dns setting to disable the DNS plugin that is on be default. set container network <network> no-name-server
c-po
force-pushed
the
Allow_Container_DNS_Disable
branch
from
September 11, 2024 05:43
bd12528
to
1d5625d
Compare
@Mergifyio backport sagitta circinus |
✅ Backports have been created
|
sever-sever
approved these changes
Sep 11, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to set the container network with a disable-dns setting to disable the DNS plugin that is on be default.
Change Summary
This changes allows one to configure a container network without using the built-in DNS plugin.
Types of changes
Related Task(s)
https://vyos.dev/T6701
Related PR(s)
Component(s) name
podman
Proposed changes
Adds ability to set disable-dns on a container network
set container network PODNET disable-dns
How to test
You should have no DNS port 53 shown on the ports used for the container network.
Without the "disable-dns" setting, you will see a UDP port 53 owned by the "aardvark-dns" process
udp 0 0 10.10.10.1:53 0.0.0.0:* 25950/aardvark-dns
Smoketest result
Checklist: