Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6701: Added ability to disable the container DNS plugin (backport #4032) #4052

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 12, 2024

Add ability to set the container network with a disable-dns setting to disable the DNS plugin that is on be default.

Change Summary

This changes allows one to configure a container network without using the built-in DNS plugin.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6701

Related PR(s)

Component(s) name

podman

Proposed changes

Adds ability to set disable-dns on a container network

set container network PODNET disable-dns

How to test

set container network PODNET prefix '10.10.10.0/24'
set container network PODNET disable-dns
commit

run show ip port | grep 10\.10\.10\.1 | grep 53

You should have no DNS port 53 shown on the ports used for the container network.

Without the "disable-dns" setting, you will see a UDP port 53 owned by the "aardvark-dns" process

udp 0 0 10.10.10.1:53 0.0.0.0:* 25950/aardvark-dns

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #4032 done by [Mergify](https://mergify.com).

Add ability to set the container network with a disable-dns setting to disable
the DNS plugin that is on be default.

  set container network <network> no-name-server

(cherry picked from commit 1d5625d)
@mergify mergify bot requested a review from a team as a code owner September 12, 2024 05:27
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Sep 12, 2024
Copy link

👍
No issues in PR Title / Commit Title

@sever-sever sever-sever merged commit 7b9ac52 into sagitta Sep 13, 2024
9 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-4032 branch September 13, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

4 participants