-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow arbitrary revert reason strings #2509
allow arbitrary revert reason strings #2509
Conversation
5c6fc29
to
f3d7d68
Compare
Codecov Report
@@ Coverage Diff @@
## master #2509 +/- ##
=======================================
Coverage 84.63% 84.64%
=======================================
Files 94 94
Lines 9273 9292 +19
Branches 2093 2096 +3
=======================================
+ Hits 7848 7865 +17
- Misses 940 941 +1
- Partials 485 486 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test that a non-string causes a compiler error
and document it
What I did
Fix #2449
How I did it
A bit of magic
How to verify it
I will write some tests
Description for the changelog
Allow variable revert reason strings
Cute Animal Picture