allow arbitrary revert reason strings

[charles-cooper]

What I did

Fix #2449

How I did it

A bit of magic

How to verify it

I will write some tests

Description for the changelog

Allow variable revert reason strings

Cute Animal Picture

[codecov-commenter]

Codecov Report

Merging #2509 (2a4972f) into master (cec2c53) will increase coverage by 0.00%.
The diff coverage is 75.75%.

❗ Current head 2a4972f differs from pull request most recent head f47906d. Consider uploading reports for the commit f47906d to get more accurate results

@@           Coverage Diff           @@
##           master    #2509   +/-   ##
=======================================
  Coverage   84.63%   84.64%           
=======================================
  Files          94       94           
  Lines        9273     9292   +19     
  Branches     2093     2096    +3     
=======================================
+ Hits         7848     7865   +17     
- Misses        940      941    +1     
- Partials      485      486    +1     

Impacted Files	Coverage Δ
vyper/old_codegen/stmt.py	86.61% <71.42%> (-1.34%)	⬇️
vyper/semantics/validation/local.py	90.83% <100.00%> (+0.14%)	⬆️
vyper/builtin_functions/functions.py	89.32% <0.00%> (+0.34%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec2c53...f47906d. Read the comment docs.

[fubuloubu]

Test that a non-string causes a compiler error

[charles-cooper]

It's there!
https://github.com/vyperlang/vyper/pull/2509/files#diff-d1c4390dd579f4bfb7256e360345f07ee912452dd8c4a0dfc68a44cf105c92d1R45