fix codegen failure with nonreentrant keys #2514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codegen now fails (stops compiling) as of eae0eaf. This is because
the storage layout is generated correctly but the type metadata is not
updated after the first function that references a nonreentrancy key.
This commit also adds a codegen test to check codegen of repeated
nonreentrancy keys.
What I did
Fix bug introduced in #2439
How I did it
How to verify it
Check the following contract fails to compile on master but compiles on this branch
Description for the changelog
Cute Animal Picture