Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix codegen failure with nonreentrant keys #2514

Merged
merged 2 commits into from
Oct 26, 2021
Merged

fix codegen failure with nonreentrant keys #2514

merged 2 commits into from
Oct 26, 2021

Commits on Oct 26, 2021

  1. fix codegen failure with nonreentrant keys 

    codegen now fails (stops compiling) as of eae0eaf. This is because
the storage layout is generated correctly but the type metadata is not
updated after the first function that references a nonreentrancy key.

This commit also adds a codegen test to check codegen of repeated
nonreentrancy keys.
    @charles-cooper
    charles-cooper committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    7fbb6c6 View commit details
    Browse the repository at this point in the history

  2. clarify the test 

    it works on either nonreentrant function calling the other
    @charles-cooper
    charles-cooper committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    efe4666 View commit details
    Browse the repository at this point in the history