Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[lang]: fix certain varinfo comparisons #4164

Merged
merged 8 commits into from
Aug 7, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jun 22, 2024

What I did

fix #4163

How I did it

How to verify it

Commit message

for `VarInfo`s which are declared in memory, the `VarInfo`
initialization is missing `decl_node`, and therefore different
variables with the same type get detected as overlapping in loop
iterator modification detection. this commit properly initializes
memory `VarInfo`s with the appropriate `decl_node`.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

for `VarInfo`s which are declared in memory, the `VarInfo`
initialization is missing `decl_node` and therefore different variables
with the same type get detected as overlapping in loop iterator
modification detection. this commit properly initializes the `VarInfo`s
in memory.
@cyberthirst cyberthirst added this to the v0.4.1 milestone Jul 29, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.72%. Comparing base (99304da) to head (562183a).

❗ There is a different number of reports uploaded between BASE (99304da) and HEAD (562183a). Click for more details.

HEAD has 139 uploads less than BASE
Flag BASE (99304da) HEAD (562183a)
140 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4164       +/-   ##
===========================================
- Coverage   91.36%   44.72%   -46.65%     
===========================================
  Files         109      109               
  Lines       15614    15616        +2     
  Branches     3436     3437        +1     
===========================================
- Hits        14266     6984     -7282     
- Misses        919     8028     +7109     
- Partials      429      604      +175     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper marked this pull request as ready for review August 7, 2024 12:17
@cyberthirst cyberthirst self-requested a review August 7, 2024 12:31
@charles-cooper charles-cooper enabled auto-merge (squash) August 7, 2024 14:19
@charles-cooper charles-cooper changed the title fix[lang]: fix varinfo comparison fix[lang]: fix certain varinfo comparisons Aug 7, 2024
@charles-cooper charles-cooper merged commit 07ddea6 into vyperlang:master Aug 7, 2024
156 checks passed
@charles-cooper charles-cooper deleted the fix/varinfo-compare branch August 8, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot modify loop variable issue when trying to append something to an array during a loop.
2 participants