-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cursor.request #257
Add cursor.request #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on!
index.bs
Outdated
@@ -4690,6 +4691,9 @@ object is modified, those modifications will be seen by anyone | |||
inspecting the value of the cursor. However modifying such an object | |||
does not modify the contents of the database. | |||
|
|||
The <dfn attribute for=IDBCursor>request</dfn> attribute's getter must | |||
return the [=cursor/request=] of this [=cursor=]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, it looks like the spec uses "the cursor" more frequently than "this cursor". (Ideally the spec would be self-consistent already)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this from {{IDBCursor/source}}
, shall I update that too?
@inexorabletash issues should be addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, forgot 3 things:
- Add "new in this edition" box
- Add bullet to Revision History section
- Add yourself to Acknowledgements
@inexorabletash done! |
index.bs
Outdated
@@ -7184,6 +7198,7 @@ For the revision history of the second edition, see [that document's Revision Hi | |||
* Updated [partial interface definition](#global-scope) since {{WindowOrWorkerGlobalScope}} is now a `mixin` ([PR #238](https://github.com/w3c/IndexedDB/pull/238)). | |||
* Added {{IDBFactory/databases()}} method. ([Issue #31](https://github.com/w3c/IndexedDB/issues/31)) | |||
* Added {{IDBTransaction/commit()}} method. ([Issue #234](https://github.com/w3c/IndexedDB/issues/234)) | |||
* Added {{IDBCursor/request}} attribute. ([Issue #234](https://github.com/w3c/IndexedDB/issues/255)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Issue #255
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
@inexorabletash done 😄 |
Define new |request| attribute on IDBCursor. Discussed in #255 WPT PR ready to land: web-platform-tests/wpt#15820 Implementations pending, but this should be fairly straightforward so going ahead with landing this (and tests) optimistically.
Closes #255
The following tasks have been completed:
Implementation commitment: See #255.
Preview | Diff