Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark IDBCursor's request property as [SameObject] #262

Closed
Yannic opened this issue Apr 29, 2019 · 1 comment · Fixed by #263
Closed

Mark IDBCursor's request property as [SameObject] #262

Yannic opened this issue Apr 29, 2019 · 1 comment · Fixed by #263

Comments

@Yannic
Copy link
Contributor

Yannic commented Apr 29, 2019

I'm working on implementing {#255, #257} for Chromium and noticed that the property is not annotated with [SameObject] in the IDL https://w3c.github.io/IndexedDB/#cursor-interface.

From the WPT for this feature and the video about the spec change, it looks like [SameObject] should be applied. If it is, I'll submit a PR adding this.

@jakearchibald
@jakearchibald
Copy link
Contributor

Yes, it should be [SameObject], sorry!

Yannic added a commit to Yannic/IndexedDB that referenced this issue Apr 29, 2019
@Yannic
Mark IDBCursor's request property as [SameObject]
4d025cb 
Closes w3c#262
Yannic added a commit to Yannic/IndexedDB that referenced this issue Apr 29, 2019
@Yannic
Mark IDBCursor's request property as [SameObject]
8e09400 
Closes w3c#262
@Yannic Yannic mentioned this issue Apr 29, 2019
Merged
2 tasks
inexorabletash pushed a commit that referenced this issue Apr 30, 2019
@Yannic @inexorabletash
Mark IDBCursor's request property as [SameObject] (#263)
bd2e28e 
Closes #262
inexorabletash pushed a commit that referenced this issue Feb 1, 2021
@Yannic @inexorabletash
Mark IDBCursor's request property as [SameObject] (#263)
20359e5 
Closes #262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark IDBCursor's request property as [SameObject] Yannic/IndexedDB
2 participants
@jakearchibald @Yannic