Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark IDBCursor's request property as [SameObject] #263

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Apr 29, 2019

Closes #262

  • Confirmed there are no ReSpec/BikeShed errors or warnings.
  • Modified Web platform tests (link to pull request)

Preview | Diff

@inexorabletash
Copy link
Member

Marked as non substantive for IPR from ash-nazg.

@inexorabletash
Copy link
Member

The test at https://github.com/web-platform-tests/wpt/blob/master/IndexedDB/idbcursor-request.any.js#L19 already asserts that the returned request matches a previously minted one, so I think this is covered. We could repeat the assertion (i.e. call cursor.request twice) but that's probably overkill.

@inexorabletash inexorabletash merged commit bd2e28e into w3c:master Apr 30, 2019
@inexorabletash
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark IDBCursor's request property as [SameObject]
2 participants