Update StructuredCloneWithTransfer() usage #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not entirely related to this PR, but the spec for ServiceWorker.postMessage looks not entirely correct. We call "Run Service Worker", which in parallel creates the workers global object, yet postMessage in the next step tries to synchronously access that global (which hasn't been created yet at that point). It seems instead postMessage should synchronously serialize the message, and then queue a task on the worker to actually deliver the message event after the worker has started up? |
domenic
force-pushed
the
fix-structured-clone
branch
from
173475e
to
3d417de
Compare
|
@jungkees updated |
domenic
force-pushed
the
fix-structured-clone
branch
from
3d417de
to
066d0d5
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1089.