Handle deserialization failures in postMessage() #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 20, 2017
Follows w3c/ServiceWorker#1130. The actual situations in which this will be called is being tested as part of #5003.
|
Awesome. I'll rebase this and ping once we get whatwg/html#2530 merged. |
This is part of whatwg/html#2530; see related links there for more information. Closes w3c#1116. Also makes some minor updates to stop referencing terms that have been removed from HTML.
|
@jungkees this has been rebased on master and is ready to merge, with tests at web-platform-tests/wpt#5628 |
|
Thanks @domenic! Great that you cleaned up the kill a worker references too. |
|
Would someone be able to review web-platform-tests/wpt#5628 ? It's pretty small, just testing the attribute reflection. |
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 1, 2017
Follows w3c/ServiceWorker#1130. The actual situations in which this will be called is being tested as part of #5003.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of whatwg/html#2530; see related links there for more information. Closes #1116.
It is on top of #1102, so that needs to be merged first. In addition, the HTML PR needs to be merged first so that the messageerror event type is actually defined somewhere; once that's done the Bikeshed HTML needs to be regenerated.
Also, this needs some tests, which I will write.