Use ExtendableMessageEvent for messageerror in service workers. #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems inconsistent to use ExtendableMessageEvent for message events but not for messageerror events. This fixes that inconsistency.
|
Ah, I asked about this on the Chromium CL before seeing this spec PR. This makes sense to me. Do we know if browsers are already doing this? Maybe it's worth making a spec issue and linking to it from here. |
mfalken
approved these changes
Nov 26, 2019
|
I'll go ahead and merge. There are WPT tests for messageerror to be added in an upcoming Chromium patch: https://chromium-review.googlesource.com/c/chromium/src/+/1921521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems inconsistent to use ExtendableMessageEvent for message events but not for messageerror events. This fixes that inconsistency.
Preview | Diff