Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need whitespace consistency for computedlabel in WPT tests #192

Closed
cookiecrook opened this issue Apr 25, 2023 · 2 comments
Closed

Need whitespace consistency for computedlabel in WPT tests #192

cookiecrook opened this issue Apr 25, 2023 · 2 comments
Milestone

Comments

@cookiecrook
Copy link
Contributor

cookiecrook commented Apr 25, 2023

Need whitespace trimming consistency for computedlabel in WPT tests.

I recalled that AccName trimmed whitespace in each step and once again at the end. However in this WPT review comment, @spectranaut noted that it either never did, or has been changed to remove those requirements. I started digging and noticed there were many outstanding whitespace and trimming related issues in the AccName WhiteSpace Project.

Until there is a required whitespace consistency in AccName, we've resolved to trim the whitespace before comparison in WPT, normalizing the testing result even if the implementations have minor differences. If there is a resolution to address trimming again in AccName, please file a related issue to cull this workaround from /wai-aria/scripts/aria-util.js in the WPT source. Thanks.

cookiecrook added a commit to cookiecrook/wpt that referenced this issue Apr 25, 2023
@jnurthen jnurthen added this to the 2023H2 milestone Apr 27, 2023
@cookiecrook
Copy link
Contributor Author

I think this can be closed? Nothing to do here except wait for the whitespace project to complete.

@accdc
Copy link
Contributor

accdc commented Oct 11, 2023

I believe it can be closed since it will be resolved when the other project is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

No branches or pull requests

3 participants