Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1 of accname name computation tests #39604

Merged
merged 9 commits into from
Apr 25, 2023
Merged

v1 of accname name computation tests #39604

merged 9 commits into from
Apr 25, 2023

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook marked this pull request as ready for review April 20, 2023 00:39
This was referenced Apr 20, 2023
Merged
Merged
@cookiecrook cookiecrook assigned cookiecrook and unassigned joanmarie Apr 20, 2023
@cookiecrook
Copy link
Contributor Author

cookiecrook commented Apr 20, 2023 •
edited
Loading

The log of the unsuccessful wpt-decision-task check means nothing to me, and the "re-run" button doesn't work. Any ideas are appreciated.

@cookiecrook cookiecrook marked this pull request as ready for review April 21, 2023 17:47
@cookiecrook cookiecrook enabled auto-merge (squash) April 21, 2023 17:50
@cookiecrook
Copy link
Contributor Author

Okay @spectranaut and @scottaohara this is really ready for review now that the PR checks have completed successfully.

@cookiecrook cookiecrook mentioned this pull request Apr 22, 2023
Closed
spectranaut
spectranaut requested changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to hear your thoughts on my one suggestion before approving!

accname/name/comp_host_language_label.html Show resolved Hide resolved
accname/name/comp_text_node.html Show resolved Hide resolved
@cookiecrook cookiecrook mentioned this pull request Apr 25, 2023
Closed
@cookiecrook cookiecrook mentioned this pull request Apr 25, 2023
Open
spectranaut
spectranaut approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, this is a great start!

@cookiecrook cookiecrook merged commit c94062e into web-platform-tests:master Apr 25, 2023
@cookiecrook
Copy link
Contributor Author

Hmmm… auto-merge bypassed the "do not merge yet" label.

@cookiecrook
Copy link
Contributor Author

But it looks like it got everything, so I think that's okay?

@cookiecrook cookiecrook deleted the accname-v1 branch April 25, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnurthen jnurthen jnurthen left review comments

@spectranaut spectranaut spectranaut approved these changes

@scottaohara scottaohara Awaiting requested review from scottaohara

@halindrome halindrome Awaiting requested review from halindrome

Assignees

@cookiecrook cookiecrook

Labels
accessibility accname wai-aria wg-wai_pf
Projects
None yet
Milestone
No milestone
6 participants
@cookiecrook @spectranaut @jnurthen @joanmarie @wpt-pr-bot @moz-wptsync-bot