-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links to Carousel Example with Buttons for Slide Control #1530
Conversation
Thanks @spectranaut ! |
done @carmacleod thx! :) |
I think the same issue is fixed for a 3rd page with #1524 😄 |
The fixes in this PR are in aria-practices.html and examples/carousel/carousel-2-tablist.html, Does the script that generates examples/index.html (reference-tables.js, I believe?) run automatically? |
Sorry, I was just trying to say I think it's broken in a third place 😆 #1524 would make it run automatically, and also add a local commit hook as well, but I don't want to derail this PR thread |
Ohhh! Sorry! Now that I read your sentence more carefully, I totally get what you were saying. Oops! 😳 And thanks for the reply about running automatically - I should have read the comment in #1524 instead of just jumping to the Files changed tab to look for the broken link fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This PR is good to go.
Thanks, @spectranaut !
|
I just notice the link to the first carousel example is broken in master:
Preview | Diff