fix: Broken CSS links and anchor tags

[nschonni]

Was tring to figure out a link checker solution. Didn't find anything yet, but one did flag thesee (along with the ones @spectranaut is fixing in #1530)

---

Preview | Diff

[carmacleod]

+1

Nice! I verified that all links were broken, and this PR fixes them.

Just curious - what was the name of that link checker? Seems to work... 😄

[nschonni]

https://github.com/JustinBeckwith/linkinator/
I might submit something with it later, but the CLI doesn't seem great. I had to create an index.html page and link to the files in order for it to really pick up the changes. I'll take a look at a CI action after this and the other carosel one lands with a hacky approach of renaming aria-practices to index.html 😆

[github-actions]

Examples without any regression tests:

button/button_idl.html
dialog-modal/alertdialog.html


Examples missing some regression tests:

combobox/combobox-autocomplete-both.html:
    combobox-id
combobox/combobox-autocomplete-list.html:
    combobox-id
combobox/combobox-autocomplete-none.html:
    combobox-id
combobox/grid-combo.html:
    textbox-key-down-arrow
    textbox-key-up-arrow
dialog-modal/datepicker-dialog.html:
    textbox-aria-describedby
menu-button/menu-button-actions-active-descendant.html:
    menu-up-arrow
    menu-down-arrow
    menu-character
spinbutton/datepicker-spinbuttons.html:
    spinbutton-down-arrow
    spinbutton-up-arrow
    spinbutton-page-down
    spinbutton-page-up
    spinbutton-home
    spinbutton-end
toolbar/toolbar.html:
    toolbar-tab
    toolbar-right-arrow
    toolbar-left-arrow
    toolbar-home
    toolbar-end
    toolbar-toggle-esc
    toolbar-toggle-enter-or-space
    toolbar-radio-enter-or-space
    toolbar-radio-down-arrow
    toolbar-radio-up-arrow
    toolbar-button-enter-or-space
    toolbar-menubutton-enter-or-space-or-down-or-up
    toolbar-menu-enter-or-space
    toolbar-menu-down-arrow
    toolbar-menu-up-arrow
    toolbar-menu-escape
    toolbar-spinbutton-down-arrow
    toolbar-spinbutton-up-arrow
    toolbar-spinbutton-page-down
    toolbar-spinbutton-page-up
    toolbar-checkbox-space
    toolbar-link-enter-or-space
    toolbar-aria-controls
    toolbar-button-aria-pressed
    toolbar-button-aria-hidden
    toolbar-radiogroup-role
    toolbar-radiogroup-aria-label
    toolbar-radio-role
    toolbar-radio-aria-checked
    toolbar-radio-aria-hidden
    toolbar-button-aria-disabled
    toolbar-menubutton-aria-label
    toolbar-menubutton-aria-haspopup
    toolbar-menubutton-aria-controls
    toolbar-menubutton-aria-expanded
    toolbar-menu-role
    toolbar-menu-aria-label
    toolbar-menuitemradio-role
    toolbar-menuitemradio-aria-checked
    toolbar-menuitemradio-tabindex
    toolbar-spinbutton-role
    toolbar-spinbutton-aria-label
    toolbar-spinbutton-aria-valuenow
    toolbar-spinbutton-aria-valuetext
    toolbar-spinbutton-aria-valuemin
    toolbar-spinbutton-aria-valuemax


Examples documentation table rows without data-test-ids:

dialog-modal/alertdialog.html
    "Keyboard Support" table(s):
       Tab
       Shift + Tab
       Escape
       Command + S
       Control + S
    "Attributes" table(s):
       alertdialog
       aria-labelledby=IDREF
       aria-describedby=IDREF
       aria-modal=true
       alert

SUMMARTY:

  55 example pages found.
  2 example pages have no regression tests.
  8 example pages are missing approximately 61 out of approximately 775 tests.

ERROR - missing tests:

  Please write missing tests for this report to pass.

[mcking65]

@nschonni Oops, just did another merge that outdated your rebase.

BTW, I've had it on the list for a long time to rename aria-practices.html to index.html, but have waited for a non-disruptive time to do it. I'd like to do it just after we publish 1.2. That's mainly because I'm not clear on what rename will do to the history, and we use the history to generate our detailed change log for the wiki.

[nschonni]

@mcking65 no worries, just rebase them all again for whichever you want to go with.

I think you can still still see the full history with the --follow flag https://stackoverflow.com/a/2314757/455535 but GitHub won't show anything in the blame.

I'd also suggest getting rid of aria-practices-DeletedSectionsArchive.html if you're cleaning up

[carmacleod]

I'd also suggest getting rid of aria-practices-DeletedSectionsArchive.html if you're cleaning up

Please don't get rid of the Deleted Sections Archive. It contains valuable historical context. There's nowhere else that still has info on the Rich Text Editor pattern, for example, and its discussion about using Ctrl + M to allow tabbing out of the editor widget. 😄

[mcking65]

@carmacleod

Please don't get rid of the Deleted Sections Archive. It contains valuable historical context. There's nowhere else that still has info on the Rich Text Editor pattern, for example, and its discussion about using Ctrl + M to allow tabbing out of the editor widget. 😄

If there is anything valuable remaining, we should find a way to harvest it. I do tink we should eliminate it soon ... it is more of a problem than a help.

[nschonni]

@carmacleod @mcking65 pulled out the deletion conversation to #1545