-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial draft of proposed Registry process #49
Conversation
Merge pull request w3c#42 from LegReq/main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I originally misunderstood the proposal a bit. I thought the proposal was that this would become a registry primarily for adding concrete DID method evaluations. But apparently it's a registry for adding new criteria plus some other things like example evaluations. I think this is super useful! I also like how it mentions that evaluations can happen elsewhere (see #45). +1 to this.
The issue was discussed in a meeting on 2021-08-31
View the transcript7. DID RubricSee github pull request did-rubric#49. Joe Andrieu: This is the PR that has the proposed registry rules for the DID Rubric registry Brent Zundel: is there a link to this presentation? Joe Andrieu: I will share a link with the mailing list
Joe Andrieu: all of these were gaps in the Rubric Brent Zundel: RE deadlines, as a WG, we have 4 more WG meetings that we can use to have this conversation Joe Andrieu: The proposal follows the template of the DID Spec Registries doc Brent Zundel: we have 10 mins left to discuss Drummond Reed: Looking for some clarification here, I originally understood from the last call that this is about the registering of evaluations, but it seems this is about registering criteria. Is this about one or both? Ted Thibodeau Jr.: I am really happy about how the Rubric is evolving. I very much like this path, and I hope it continues evolving forever. Joe Andrieu: I'm very glad to see that. The work of evolving the Rubric has taught us a great deal, and it will continue. Kyle Den Hartog: I also want to second its usefulness. We learned a lot when evaluating Drummond Reed: what are next steps? Brent Zundel: Next steps are to review the PR ASAP Joe Andrieu: I will send out an email to the list with the PR and ask for feedback. Brent Zundel: That looks great. Looking forward to the feedback. Kyle Den Hartog: Wanted to say thanks for accommodating this time zone for one meeting a month
Brent Zundel: Thanks to everyone, and especially Joe for the Rubric registry PR, and to scribes, and to wrapping it all up in Sept. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comment is purely editorial.
- Wouldn't it be cleaner if all current entries in §3 followed exactly the same structure (in terms of subtitles) as the entries listed in §2.2? This is mostly done, but the name, id, and version, are never made explicit in §3 (I realize those items are all trivially there, but it would probably be better to make it 100% explicit).
- "Each criteria must be explicitly, uniquely, and persistently identified using incremental numbers. New criteria should use the next available increment based on the highest numbered identifier in the current publication." which is fine, but we may create a race condition, so it should be made clear that the editors of the registry may have to adapt those numbers during the registration process itself.
- I would think that §3.9 should either be removed or, rather, refer to the registration process.
- Shouldn't something be said, in §2, who maintains the registry? Who has the decision power, at the end of the day, on whether a submission abides to the rules? I presume it is, officially, the maintainer of the DID Spec proper, ie, the DID WG or, in the absence thereof, the W3C Team, but that has to be made more explicit imho.
- "vioations" -> "violations" (in second bullet §2.1
Adopted all of @TallTed's initial suggestions, up through where we need more definition for "element" Co-authored-by: Ted Thibodeau Jr <[email protected]>
The issue was discussed in a meeting on 2021-09-07
View the transcript2.1. Initial draft of proposed Registry process (pr did-rubric#49)See github pull request did-rubric#49. Daniel Burnett: main point is to convert DID rubric to a registry - this is an issue that is out Drummond Reed: more in-depth and complex Markus Sabadello: I misunderstood this proposal at first - it is just one part of it - just about adding additional criteria - I like it Ivan Herman: I read it this morning - important to have it done as quickly as possible - so put in DID new charter that this will turn into an official registry document.
Ted Thibodeau Jr.: I had started going over this with a fine tooth comb and made a stack of suggestions - I didn't quite understand how things were flowing as documents - main author should go through my comments and then I can do - they have been sitting there for 5 days Daniel Burnett: If he wants this to get in he needs to be very responsive to comments |
<h4>Criteria.Examples.Notes</h4> | ||
<ol> | ||
<li>This entry SHOULD include any details that help explain | ||
why that particular response was chosen.It MAY be blank. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why that particular response was chosen.It MAY be blank. | |
why that particular response was chosen. It MAY be blank. |
The issue was discussed in a meeting on 2021-09-14 List of resolutions:
View the transcript5. Initial draft of proposed Registry process (pr did-rubric#49)See github pull request did-rubric#49. Brent Zundel: PR 49 has been open for a while Joe Andrieu: Would be good to get a formal approval to accept this. Still some editorial to do.
Brent Zundel: as soon as the PR gets editorial cleanups we can merge. Thanks all!
Joe Andrieu: thanks for your support! Ivan Herman: to be clear, we expect new DID charter will change after formal objection is resolved. Once your PR is merged I can take out the caveat we have in the charter text, right? Brent Zundel: yes |
Moved to issue #56 |
The section on 2.3 Identifiers says
Does this address your suggestion, Ivan? Or is there another place in the document we should/could highlight that point better? |
Agreed. I added a new issue to track this. We should also get rid of the "additional criteria" section or at least update it to fit with the registry. |
Hmmm. We do say that at the end of Section 2, but it's not well highlighted. I'll break that out into its own section, 2.6. |
Co-authored-by: Charles E. Lehner <[email protected]>
Co-authored-by: Charles E. Lehner <[email protected]>
@dhh1128 This should be ready to go. I've created a few new issues to track some good suggestions that I'd like to get in later, but those are all editorial and shouldn't hold up this merge. Let me know if you have any questions. |
This outlines a set of proposed rules for managing the DID Method Rubric as a registry.
Preview | Diff